src: use uv_gettimeofday() #27029
src: use uv_gettimeofday() #27029
Conversation
nodejs-github-bot
added
the
lib / src
| uv_timeval_t ts; | ||
| if (uv_gettimeofday(&ts) == 0) { | ||
| writer.json_keyvalue("dumpEventTimeStamp", | ||
| std::to_string(ts.tv_sec * 1000 + ts.tv_usec / 1000)); |
There was a problem hiding this comment.
This might overflow when tv_sec is a 32 bits long.
(I kind of regret that we didn't use int64_t for uv_timeval_t.tv_sec...)
There was a problem hiding this comment.
Maybe there's still time to change uv_gettimeofday to uint64_t uv_gettimeofday() (or unsigned long long int) and always return microseconds? Seems like uv_timeval_t is a little "legacy" for this API
There was a problem hiding this comment.
That's not a bad idea. Since uv_gettimeofday() hasn't been released yet, there is time.
There was a problem hiding this comment.
We can discuss at libuv/libuv#2243.
|
@bnoordhuis I think I've addressed your nits with the new libuv release. |
|
CI: https://ci.nodejs.org/job/node-test-pull-request/22640/ EDIT(cjihrig): CI was green. |
dumpEventTimeStamp was not implemented on Windows, and did not include any error checking. This commit adds Windows support and error checking. PR-URL: nodejs#27029 Reviewed-By: Refael Ackermann <refack@gmail.com>
Use uv_gettimeofday() in GetCurrentTimeInMicroseconds() to remove the need for #ifdef logic. PR-URL: nodejs#27029 Reviewed-By: Refael Ackermann <refack@gmail.com>
|
Landed in 90cf2d5...8e1e994. |
Labeled as a WIP until the next libuv update (ignore the first commit here).
The next version of libuv will provide
uv_gettimeofday()as a cross platform alternative togettimeofday().Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes