Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fs: improve mode and flags validation #27044

Closed
wants to merge 3 commits into from
Closed

fs: improve mode and flags validation #27044

wants to merge 3 commits into from

Commits on Jan 11, 2020

  1. doc: fix mode and flags being mistaken in fs 

    Multiple `fs` functions have a `mode` and or `flag` option. In some
cases those have been mistaken and named wrongly. All of those faulty
entries have been fixed.
Besides that some indentation is also aligned with the rest of the
document.
    @BridgeAR
    BridgeAR committed Jan 11, 2020
    Configuration menu
    Copy the full SHA
    ceb8df9 View commit details
    Browse the repository at this point in the history

  2. fs: improve mode and flags validation 

    This fixes a few bugs in `fs`. E.g., `fs.promises.access` accepted
strings as mode. It should have only accepted numbers. It will now
always validate the flags and the mode argument in an consistent way.
    @BridgeAR
    BridgeAR committed Jan 11, 2020
    Configuration menu
    Copy the full SHA
    047fbc8 View commit details
    Browse the repository at this point in the history

  3. doc: use shorter fs.copyFile examples 

    This consolidates some examples to concentrate the reader on the
important aspects and to reduce reading overhead.
    @BridgeAR
    BridgeAR committed Jan 11, 2020
    Configuration menu
    Copy the full SHA
    acc80ae View commit details
    Browse the repository at this point in the history