Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tools: print a better message for unexpected use of globals #27083

Closed
wants to merge 2 commits into from
Closed

tools: print a better message for unexpected use of globals #27083

wants to merge 2 commits into from

Conversation

targos
Copy link
Member

@targos targos commented Apr 4, 2019

The error looks like this now:

  23:11  error  Unexpected use of 'Reflect'. Use `const { Reflect } = primordials;` instead of the global  no-restricted-globals

@nodejs-github-bot
Copy link
Collaborator

Lite-CI: https://ci.nodejs.org/job/node-test-pull-request-lite-pipeline/3165

@targos targos mentioned this pull request Apr 4, 2019
Closed
3 tasks
@ZYSzys ZYSzys added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. tools Issues and PRs related to the tools directory. labels Apr 4, 2019
@targos
Copy link
Member Author

targos commented Apr 6, 2019

Landed in dd89a11

@targos targos closed this Apr 6, 2019
@targos targos deleted the primordials-message branch April 6, 2019 14:16
targos added a commit that referenced this pull request Apr 6, 2019
@targos
tools: print a better message for unexpected use of globals
dd89a11 
PR-URL: #27083
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
This was referenced Apr 23, 2019
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lpinca lpinca lpinca approved these changes

@cjihrig cjihrig cjihrig approved these changes

@richardlau richardlau richardlau approved these changes

@BridgeAR BridgeAR BridgeAR approved these changes

@ZYSzys ZYSzys ZYSzys approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. tools Issues and PRs related to the tools directory.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@targos @nodejs-github-bot @lpinca @cjihrig @richardlau @BridgeAR @ZYSzys