Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

benchmark: remove deprecated argument #27091

Closed
wants to merge 1 commit into from
Closed

Commits on Apr 5, 2019

  1. benchmark: remove deprecated argument

    The benchmarks for dns.lookup() include calling it with an empty
    hostname which results in a deprecation warning. This benchmark seems to
    be subject to some odd side effects (see Ref below) and we probably
    generally don't want to benchmark deprecated things by default anyway.
    Remove the deprecated value from the default list. Bonus is that this
    will speed up the benchmark.
    
    Refs: nodejs#27081 (comment)
    Trott committed Apr 5, 2019
    Configuration menu
    Copy the full SHA
    4c9ab75 View commit details
    Browse the repository at this point in the history