Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

src: fix process.platform #271

Closed
wants to merge 1 commit into from
Closed

Conversation

vkurchatkin
Copy link
Contributor

e1fe270 introduces NODE_PLATFORM macro which had to be redefined in node.gyp for process.platform to return expected values.

Not sure about win and solaris (can't test), but for OS X process.platform returned mac instead of darwin and broke some tests.

/cc @piscisaureus

#endif
READONLY_PROPERTY(process, "platform", platform);
READONLY_PROPERTY(process, "platform",
OneByteString(env->isolate(), NODE_PLATFORM));
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Style: indentation is off here.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The former is the preferred style. The latter is for when the former would exceed 80 columns.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed

e1fe270 introduces NODE_PLATFORM macro which had to be redefined
in node.gyp for `process.platform` to return expected values.
@bnoordhuis
Copy link
Member

LGTM. I'll let @piscisaureus sign off on it and land it.

@bnoordhuis
Copy link
Member

@vkurchatkin And thanks, of course! :-)

piscisaureus pushed a commit that referenced this pull request Jan 9, 2015
e1fe270 introduces the NODE_PLATFORM macro which had to be redefined in
node.gyp for `process.platform` to return expected values.

PR-URL: #271
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Bert Belder <bertbelder@gmail.com>
@piscisaureus
Copy link
Contributor

It was kind of a dumb mistake of me to assume that windows would be the only platform where the node platform was different from the gyp os value. I did grep for occurences of PLATFORM in source folders, but I forgot to look inside the gyp file itself.

Thanks @vkurchatkin for fixing this! Landed in 9f45799.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants