Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: print child stderr in test-http-chunk-problem #27117

Closed
wants to merge 1 commit into from
Closed

test: print child stderr in test-http-chunk-problem #27117

wants to merge 1 commit into from

Conversation

addaleax
Copy link
Member

@addaleax addaleax commented Apr 6, 2019

This helps with debugging test failures.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • commit message follows commit guidelines

@addaleax
test: print child stderr in test-http-chunk-problem
2897d0f 
This helps with debugging test failures.
@nodejs-github-bot
Copy link
Collaborator

Lite-CI: https://ci.nodejs.org/job/node-test-pull-request-lite-pipeline/3188

@nodejs-github-bot nodejs-github-bot added the test Issues and PRs related to the tests. label Apr 6, 2019
@BridgeAR BridgeAR added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Apr 9, 2019
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/22303/

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/22314/

@addaleax
Copy link
Member Author

addaleax commented Apr 9, 2019

Landed in d141330

@addaleax addaleax closed this Apr 9, 2019
@addaleax addaleax deleted the chunk-problem branch April 9, 2019 19:56
addaleax added a commit that referenced this pull request Apr 9, 2019
@addaleax
test: print child stderr in test-http-chunk-problem
d141330 
This helps with debugging test failures.

PR-URL: #27117
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Beth Griggs <Bethany.Griggs@uk.ibm.com>
Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
This was referenced Apr 23, 2019
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
This was referenced Jan 12, 2022
Open
Open
Open
Open
Open
This was referenced Jan 12, 2022
Open
Open
Open
Open
Open
This was referenced Feb 9, 2022
Open
Open
Open
Open
Open
Open
Open
Open
Open
Open
@kissofire kissofire mentioned this pull request May 22, 2024
Open
@137717unity 137717unity mentioned this pull request May 22, 2024
Open
@wedataintelligence wedataintelligence mentioned this pull request May 22, 2024
Open
@baby636 baby636 mentioned this pull request May 22, 2024
Open
@aliceUnhinged613 aliceUnhinged613 mentioned this pull request May 23, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ZYSzys ZYSzys ZYSzys approved these changes

@BridgeAR BridgeAR BridgeAR approved these changes

@BethGriggs BethGriggs BethGriggs approved these changes

@cjihrig cjihrig cjihrig approved these changes

@jasnell jasnell jasnell approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. test Issues and PRs related to the tests.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@addaleax @nodejs-github-bot @jasnell @cjihrig @BethGriggs @BridgeAR @ZYSzys