Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: skip test_lookup_ipv6_hint on FreeBSD #2716

Closed
wants to merge 1 commit into from
Closed

test: skip test_lookup_ipv6_hint on FreeBSD #2716

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 9 additions & 0 deletions test/internet/test-dns.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -390,6 +390,15 @@ TEST(function test_lookup_ipv6_explicit_object(done) {


TEST(function test_lookup_ipv6_hint(done) {
// FreeBSD does not support V4MAPPED flag.
if (process.platform === 'freebsd') {
console.log(
'1..0 # Skipped: test_lookup_ipv6_hint is disabled on FreeBSD.'
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can this message be changed to FreeBSD does not support V4MAPPED flag.?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@thefourtheye if so, perhaps squeeze both test_lookup_ipv6_hint and v4mapped in there? wouldn't tap just report internet/test-dns.js and not the actual test name.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jbergstroem Unfortunately, nope. It will not know the specific test :( I thought that if we specified the actual reason, it would be better to understand why it is skipped.

Now there is another interesting thing here. If we skip more than one tests in a single file, then there will be two skip TAP lines. I wonder how the output will be displayed.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@thefourtheye yeah, not too much to do about "double skipping" unless we're keen to start rewriting larger parts of our tests. Long term we should look at replacing the current runner with something build on top of node-tap or similar. There's an issue about this somewhere..

anyway, moving forward; I'm ok with either message.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Long term we should look at replacing the current runner with something build on top of node-tap or similar

cheers

);
done();
return;
}

var req = dns.lookup('www.google.com', {
family: 6,
hints: dns.V4MAPPED
Expand Down