Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

build: pin Python version in Travis #27166

Closed
wants to merge 1 commit into from
Closed

build: pin Python version in Travis #27166

wants to merge 1 commit into from

Conversation

richardlau
Copy link
Member

@richardlau richardlau commented Apr 10, 2019 •
edited
Loading

Travis will be switching the default version of Python from 2.7 to 3.6 on April 16th 2019.

This PR pins the Travis builds to Python 2.7 as we're not at Python 3 compatibility yet. If we can get there before April 16th we can drop this PR, otherwise it will be necessary for our Travis builds to continue to function.

Refs: https://changelog.travis-ci.com/upcoming-python-default-version-update-96873

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines

@richardlau richardlau added the wip Issues and PRs that are still a work in progress. label Apr 10, 2019
@nodejs-github-bot

This comment has been minimized.

Sign in to view
@nodejs-github-bot nodejs-github-bot added the build Issues and PRs related to build files or the CI. label Apr 10, 2019
@richardlau richardlau force-pushed the travispython3 branch 3 times, most recently from 125b805 to a2cc894 Compare April 10, 2019 00:49
@richardlau
Copy link
Member Author

Some notes:
So the Travis documented way of pinning the Python version:

language: python
python: '2.7'

doesn't work for non-Python projects such as ours. The Xenial images on Travis have Python 2.7.15, 3.6.7, and 3.7.1: https://docs.travis-ci.com/user/reference/xenial/#python-support
Used pyenv to switch to 3.6.7 and the compilation jobs fail because we haven't updated configure which specifically looks for a Python 2 to reexecute itself (fix pending in #25878).

So we do need to pin to 2.7.15 in the short term. Updating this PR...

@richardlau richardlau changed the title WIP build: pin Python version in Travis build: pin Python version in Travis Apr 10, 2019
@richardlau richardlau added python PRs and issues that require attention from people who are familiar with Python. and removed wip Issues and PRs that are still a work in progress. labels Apr 10, 2019
@richardlau
Copy link
Member Author

According to https://changelog.travis-ci.com/upcoming-python-default-version-update-96873

On April 16th 2019, the default Python version used to run your builds will be updated from Python 2.7 to Python 3.6

This PR pins the Travis builds to Python 2.7 as we're not at Python 3 compatibility yet. If we can get there before April 16th we can drop this PR, otherwise it will be necessary for our Travis builds to continue to function.

cc FYI @nodejs/python @cclauss

This was referenced Apr 10, 2019
Closed
Closed
@cclauss
Copy link
Contributor

cclauss commented Apr 10, 2019

Relates to travis-ci/travis-build#1678

@cclauss
Copy link
Contributor

cclauss commented Apr 10, 2019

We have a list of things to get done... #25789. What percentage of build machine have Python 3 loaded?

@richardlau
Copy link
Member Author

Lite-CI: https://ci.nodejs.org/job/node-test-pull-request-lite-pipeline/3223/

@richardlau richardlau added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Apr 10, 2019
@richardlau
build: pin Python version in Travis
1fbe324 
Travis will be switching the default version of Python from 2.7 to 3.6.
Our configuration and build scripts are not quite ready for Python 3
yet, so pin the version of Python to 2.7.
@richardlau
Copy link
Member Author

Fixed merge conflicts.

Lite-CI: https://ci.nodejs.org/job/node-test-pull-request-lite-pipeline/3239/

BridgeAR pushed a commit to BridgeAR/node that referenced this pull request Apr 15, 2019
@richardlau @BridgeAR
build: pin Python version in Travis
b468a1d 
Travis will be switching the default version of Python from 2.7 to 3.6.
Our configuration and build scripts are not quite ready for Python 3
yet, so pin the version of Python to 2.7.

PR-URL: nodejs#27166
Refs: https://changelog.travis-ci.com/upcoming-python-default-version-update-96873
Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
@BridgeAR
Copy link
Member

Landed in b468a1d 🎉

@BridgeAR BridgeAR closed this Apr 15, 2019
@richardlau richardlau deleted the travispython3 branch April 15, 2019 18:15
This was referenced Apr 23, 2019
Closed
Closed
Closed
This was referenced Apr 23, 2019
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BridgeAR BridgeAR BridgeAR approved these changes

@thefourtheye thefourtheye thefourtheye approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. build Issues and PRs related to build files or the CI. python PRs and issues that require attention from people who are familiar with Python.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@richardlau @nodejs-github-bot @cclauss @BridgeAR @thefourtheye