Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

doc: revise TSC text in GOVERNANCE.md #27169

Closed
wants to merge 1 commit into from
Closed

doc: revise TSC text in GOVERNANCE.md #27169

wants to merge 1 commit into from

Conversation

Trott
Copy link
Member

@Trott Trott commented Apr 10, 2019

Tighten up a few things to make them more concise. Clarify that changes
to the charter require board approval.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • documentation is changed or added
  • commit message follows commit guidelines

@Trott
doc: revise TSC text in GOVERNANCE.md
45aa342 
Tighten up a few things to make them more concise. Clarify that changes
to the charter require board approval.
@nodejs-github-bot
Copy link
Collaborator

Lite-CI: https://ci.nodejs.org/job/node-test-pull-request-lite-pipeline/3224

@nodejs-github-bot nodejs-github-bot added the meta Issues and PRs related to the general management of the project. label Apr 10, 2019
@vsemozhetbyt vsemozhetbyt added doc Issues and PRs related to the documentations. author ready PRs that have at least one approval, no pending requests for changes, and a CI started. labels Apr 10, 2019
mhdawson
mhdawson approved these changes Apr 11, 2019
View reviewed changes
Copy link
Member

@mhdawson mhdawson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Trott
Copy link
Member Author

Trott commented Apr 12, 2019

Landed in 7b85495

@Trott Trott closed this Apr 12, 2019
Trott added a commit to Trott/io.js that referenced this pull request Apr 12, 2019
@Trott
doc: revise TSC text in GOVERNANCE.md
7b85495 
Tighten up a few things to make them more concise. Clarify that changes
to the charter require board approval.

PR-URL: nodejs#27169
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Beth Griggs <Bethany.Griggs@uk.ibm.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
This was referenced Apr 23, 2019
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
@Trott Trott deleted the technical-steering-committee branch January 13, 2022 22:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mhdawson mhdawson mhdawson approved these changes

@BethGriggs BethGriggs BethGriggs approved these changes

@cjihrig cjihrig cjihrig approved these changes

@jasnell jasnell jasnell approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. doc Issues and PRs related to the documentations. meta Issues and PRs related to the general management of the project.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@Trott @nodejs-github-bot @jasnell @cjihrig @BethGriggs @mhdawson @vsemozhetbyt