Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: mark some known flakes #27225

Merged
merged 0 commits into from
Apr 21, 2019
Merged

test: mark some known flakes #27225

merged 0 commits into from
Apr 21, 2019

Conversation

refack
Copy link
Contributor

@refack refack commented Apr 14, 2019 •
edited
Loading

Refs: #26910 - test-tls-sni-option: PASS,FLAKY
Refs: #27219 - test-tls-sni-server-client: PASS,FLAKY
Refs: #26938 - test-tls-js-stream: PASS,FLAKY
Refs: #23089 - test-gc-http-client-onerror: PASS,FLAKY

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines

@nodejs-github-bot
Copy link
Collaborator

Lite-CI: https://ci.nodejs.org/job/node-test-pull-request-lite-pipeline/3247

@nodejs-github-bot nodejs-github-bot added the test Issues and PRs related to the tests. label Apr 14, 2019
@refack
Copy link
Contributor Author

refack commented Apr 14, 2019

/CC @nodejs/testing @nodejs/crypto

Please 👍 if you approve of fast-tracking this.

@refack refack added flaky-test Issues and PRs related to the tests with unstable failures on the CI. fast-track PRs that do not need to wait for 48 hours to land. labels Apr 14, 2019
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/22432/

@BridgeAR BridgeAR added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Apr 16, 2019
@refack refack closed this Apr 21, 2019
@refack refack removed author ready PRs that have at least one approval, no pending requests for changes, and a CI started. fast-track PRs that do not need to wait for 48 hours to land. labels Apr 21, 2019
@refack refack deleted the more-flakes-oooffff branch April 21, 2019 13:21
@refack refack added the landed label Apr 21, 2019
@refack refack merged commit 528d100 into nodejs:master Apr 21, 2019
@refack
Copy link
Contributor Author

refack commented Apr 21, 2019

Landed in 528d100

This was referenced Apr 23, 2019
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
MylesBorins pushed a commit that referenced this pull request May 16, 2019
@refack @MylesBorins
test: mark some known flakes
915ea2a 
PR-URL: #27225
Refs: #26910
Refs: #27219
Refs: #26938
Refs: #23089
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com>
MylesBorins pushed a commit that referenced this pull request May 16, 2019
@refack @MylesBorins
test: mark some known flakes
fe21dd3 
PR-URL: #27225
Refs: #26910
Refs: #27219
Refs: #26938
Refs: #23089
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com>
@BethGriggs BethGriggs mentioned this pull request May 16, 2019
Merged
This was referenced May 29, 2019
Closed
Closed
Closed
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ZYSzys ZYSzys ZYSzys approved these changes

@BridgeAR BridgeAR BridgeAR approved these changes

@richardlau richardlau richardlau approved these changes

@lpinca lpinca lpinca approved these changes

Assignees
No one assigned
Labels
flaky-test Issues and PRs related to the tests with unstable failures on the CI. test Issues and PRs related to the tests.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@refack @nodejs-github-bot @lpinca @richardlau @BridgeAR @ZYSzys @MylesBorins