doc: revise Collaborator Nominations introduction #27237
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Revise the introductory paragraphs for Collaborator Nominations in GOVERNANCE.md. This change splits long and unnecessarily complex sentences into multiple simple statements.
nodejs-github-bot
added
the
meta
apapirovski
approved these changes
Apr 15, 2019
apapirovski
reviewed
Apr 15, 2019
GOVERNANCE.md
Outdated
| Any existing Collaborator can nominate an individual making significant | ||
| and valuable contributions across the Node.js organization to become a new | ||
| Collaborator. | ||
| Existing Collaborators can nominate someone to become a new Collaborator. |
There was a problem hiding this comment.
Is “new” adding anything here? (I know it was there before too.)
cjihrig
approved these changes
Apr 15, 2019
Trott
added
the
author ready
mihalskiy
approved these changes
Apr 15, 2019
jasnell
approved these changes
Apr 15, 2019
BridgeAR
approved these changes
Apr 15, 2019
|
Landed in ba74e42 |
Trott
added a commit
to Trott/io.js
that referenced
this pull request
Apr 17, 2019
Revise the introductory paragraphs for Collaborator Nominations in GOVERNANCE.md. This change splits long and unnecessarily complex sentences into multiple simple statements. PR-URL: nodejs#27237 Reviewed-By: Anatoli Papirovski <apapirovski@mac.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
This was referenced Apr 23, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In a continued effort to make our GOVERNANCE.md easier to read and understand:
Revise the introductory paragraphs for Collaborator Nominations in
GOVERNANCE.md. This change splits long and unnecessarily complex
sentences into multiple simple statements.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes