test: expect error for test_lookup_ipv6_hint on FreeBSD #2724
Conversation
FreeBSD does not support the V4MAPPED flag so expect an error.
mscdex
added
dns
| assert(err instanceof Error); | ||
| assert.strictEqual(err.code, 'EAI_BADFLAGS'); | ||
| assert.strictEqual(err.hostname, 'www.google.com'); | ||
| assert.ok(/getaddrinfo EAI_BADFLAGS/.test(err.message)); |
There was a problem hiding this comment.
I used assert.ok() to match the style of the other regular expression-based assertions in the file. (There are five other instances.)
|
This is explicit and I like it. LGTM |
|
A test should be added that uses flags that FreeBSD supports, but I'd prefer that to be in a separate PR rather than bundled with this one. I'm just making a note here so I actually do it. |
|
Obligatory CI, although the CI won't touch this code other than linting it: https://ci.nodejs.org/job/node-test-pull-request/263/ |
|
Having a conversation with myself a bit here, but in response to my comment about there needing to be another PR with another test: Upon further investigation, there' probably doesn't need to be another test in addition to this one. It looks like |
|
LGTM |
FreeBSD does not support the V4MAPPED flag so expect an error. This is a partial fix for nodejs#2468. It only fixes it on FreeBSD. Failures on other platforms are due to other reasons and need to be fixed separately. PR-URL: nodejs#2724 Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com> Reviewed-By: Johan Bergström <bugs@bergstroem.nu> Fixes: nodejs#2468
|
Landed in f8152df |
FreeBSD does not support the V4MAPPED flag so expect an error. This is a partial fix for #2468. It only fixes it on FreeBSD. Failures on other platforms are due to other reasons and need to be fixed separately. PR-URL: #2724 Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com> Reviewed-By: Johan Bergström <bugs@bergstroem.nu> Fixes: #2468
FreeBSD does not support the V4MAPPED flag so expect an error. This is a partial fix for #2468. It only fixes it on FreeBSD. Failures on other platforms are due to other reasons and need to be fixed separately. PR-URL: #2724 Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com> Reviewed-By: Johan Bergström <bugs@bergstroem.nu> Fixes: #2468
FreeBSD does not support the V4MAPPED flag so expect an error.
/cc @jbergstroem @thefourtheye