Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: do not strip left whitespace in pseudo-tty tests #27244

Closed
wants to merge 1 commit into from
Closed

test: do not strip left whitespace in pseudo-tty tests #27244

wants to merge 1 commit into from

Conversation

BridgeAR
Copy link
Member

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines

@nodejs-github-bot
Copy link
Collaborator

Lite-CI: https://ci.nodejs.org/job/node-test-pull-request-lite-pipeline/3263

@nodejs-github-bot nodejs-github-bot added test Issues and PRs related to the tests. tty Issues and PRs related to the tty subsystem. labels Apr 15, 2019
@BridgeAR BridgeAR added the python PRs and issues that require attention from people who are familiar with Python. label Apr 15, 2019
Fishrock123
Fishrock123 approved these changes Apr 15, 2019
View reviewed changes
Copy link
Contributor

@Fishrock123 Fishrock123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pending full CI: https://ci.nodejs.org/job/node-test-pull-request/22458/

@nodejs-github-bot

This comment has been minimized.

Sign in to view
@BridgeAR BridgeAR added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Apr 15, 2019
@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Apr 15, 2019 •
edited by BridgeAR
Loading

CI: https://ci.nodejs.org/job/node-test-pull-request/22468/ ✅ (besides Windows)
Windows Rebuild: https://ci.nodejs.org/job/node-test-commit-windows-fanned/26542/ ✔️

@ZYSzys
Copy link
Member

ZYSzys commented Apr 19, 2019

Landed in ed89311 🎉

@ZYSzys ZYSzys closed this Apr 19, 2019
ZYSzys pushed a commit that referenced this pull request Apr 19, 2019
@BridgeAR @ZYSzys
test: do not strip left whitespace in pseudo-tty tests
ed89311 
PR-URL: #27244
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Beth Griggs <Bethany.Griggs@uk.ibm.com>
Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
This was referenced Apr 23, 2019
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
@BridgeAR BridgeAR deleted the do-not-strip-all-whitespace branch January 20, 2020 12:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Fishrock123 Fishrock123 Fishrock123 approved these changes

@lpinca lpinca lpinca approved these changes

@BethGriggs BethGriggs BethGriggs approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. python PRs and issues that require attention from people who are familiar with Python. test Issues and PRs related to the tests. tty Issues and PRs related to the tty subsystem.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@BridgeAR @nodejs-github-bot @ZYSzys @Fishrock123 @lpinca @BethGriggs