Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

benchmark: fix buffer-base64-decode.js #27260

Closed
wants to merge 4 commits into from
Closed
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
test: fix test-benchmark-buffer
Using `len=2` in test-benchmark-buffer was resulting in a `RangeError`
in buffer-base64-encode.js. Change to `len=256` which works in all
buffer benchmarks.
  • Loading branch information
Trott committed Apr 16, 2019
commit eab7d506006be372b9855bb75a5fc27a0c6354af
2 changes: 1 addition & 1 deletion test/benchmark/test-benchmark-buffer.js
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ runBenchmark('buffers',
'charsPerLine=6',
'encoding=utf8',
'endian=BE',
'len=2',
'len=256',
'linesCount=1',
'method=',
'n=1',
Expand Down