Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

src: split per-process initialization and teardown routines #27276

Closed
wants to merge 1 commit into from

Conversation

joyeecheung
Copy link
Member

This patch makes it possible to instantiate NodeMainInstance in
a separate target and use it to e.g. create snapshot.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines

This patch makes it possible to instantiate NodeMainInstance in
a separate target and use it to e.g. create snapshot.
@nodejs-github-bot
Copy link
Collaborator

@nodejs-github-bot nodejs-github-bot added the c++ Issues and PRs that require attention from people who are familiar with C++. label Apr 17, 2019
@nodejs-github-bot
Copy link
Collaborator

@nodejs-github-bot
Copy link
Collaborator

@joyeecheung joyeecheung added the review wanted PRs that need reviews. label Apr 18, 2019
@joyeecheung
Copy link
Member Author

Can I have another review please? @nodejs/process

@joyeecheung
Copy link
Member Author

Landed in 5356b4a

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c++ Issues and PRs that require attention from people who are familiar with C++. review wanted PRs that need reviews.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants