test: deflake test-tls-sni-option #27300

sam-github · 2019-04-18T21:41:33Z

Might fix #26910, though I haven't reproed the failure yet.

Basically, I pull next() out so that the testcase isn't complete until the client and server have finished. TLS1.2 and 1.3 complete on client and server in different orders, this might be an issue here.

Checklist

make -j4 test (UNIX), or vcbuild test (Windows) passes
tests and/or benchmarks are included
documentation is changed or added
commit message follows commit guidelines

nodejs-github-bot · 2019-04-18T21:41:34Z

Lite-CI: https://ci.nodejs.org/job/node-test-pull-request-lite-pipeline/3297

sam-github · 2019-04-19T03:13:54Z

Makes it happen less often, but doesn't eliminate the flake, I'll keep looking.

nodejs-github-bot · 2019-04-23T01:53:18Z

CI: https://ci.nodejs.org/job/node-test-pull-request/22648/

nodejs-github-bot · 2019-04-23T15:28:54Z

CI: https://ci.nodejs.org/job/node-test-pull-request/22657/

sam-github · 2019-04-23T20:35:21Z

@lpinca PTAL at the last commit, the "fixup". I used while ./out/Release/node test/parallel/test-tls-sni-option.js; do echo -n .; done to check for flakes.

lpinca · 2019-04-24T05:28:58Z

@sam-github I still get failures:

luigi@imac:node (gh-27300)$ git log  --pretty=oneline | head
cba2a1a916122d355979bff2872032bc79e834cd fixup! test: rework to remove flakiness, and be parallel
428a629fdf8f956d89dfe6187f8e9961b02c4973 test: rework to remove flakiness, and be parallel
1a54d0fa59e0e1c90db1b66907c48a286d5b26a3 dgram: change 'this' to 'self' for 'isConnected'
eac8f50ca664186d099c03dcac71a22fde89671f test: increase coverage in lib/internal/dns/promises.js
62c7b2eca9d9a53ccedd6517c955285b0732d255 benchmark: fix http bench-parser.js
b773f77ddbae7fb6b4530b0ab60e2d72aebf277f doc: fix v12.0.0 changelog id
a41a4ee61b25698394aeda277546605ea25070c1 build: disable custom v8 snapshot by default
d896f03578f2312aaae347de3b5a0b26882effc8 2019-04-23, Version 12.0.0 (Current)
fcb98bb25bd201dad9689ba43397544e6964b629 tools: update tools/license-builder.sh
859421188b0f350d0a17270a54a67f6554713d71 doc: simplify Collaborator pre-nomination text
luigi@imac:node (gh-27300)$ ./tools/test.py -J --repeat=1000 test/parallel/test-tls-sni-option.js
=== release test-tls-sni-option ===                   
Path: parallel/test-tls-sni-option
events.js:173
      throw er; // Unhandled 'error' event
      ^

Error: read ECONNRESET
    at TLSWrap.onStreamRead (internal/stream_base_commons.js:183:27)
Emitted 'error' event at:
    at emitErrorNT (internal/streams/destroy.js:91:8)
    at emitErrorAndCloseNT (internal/streams/destroy.js:59:3)
    at processTicksAndRejections (internal/process/task_queues.js:83:17)
Command: out/Release/node /Users/luigi/dev/node/test/parallel/test-tls-sni-option.js
=== release test-tls-sni-option ===                   
Path: parallel/test-tls-sni-option
events.js:173
      throw er; // Unhandled 'error' event
      ^

Error: read ECONNRESET
    at TLSWrap.onStreamRead (internal/stream_base_commons.js:183:27)
Emitted 'error' event at:
    at emitErrorNT (internal/streams/destroy.js:91:8)
    at emitErrorAndCloseNT (internal/streams/destroy.js:59:3)
    at processTicksAndRejections (internal/process/task_queues.js:83:17)
Command: out/Release/node /Users/luigi/dev/node/test/parallel/test-tls-sni-option.js
=== release test-tls-sni-option ===                   
Path: parallel/test-tls-sni-option
events.js:173
      throw er; // Unhandled 'error' event
      ^

Error: read ECONNRESET
    at TLSWrap.onStreamRead (internal/stream_base_commons.js:183:27)
Emitted 'error' event at:
    at emitErrorNT (internal/streams/destroy.js:91:8)
    at emitErrorAndCloseNT (internal/streams/destroy.js:59:3)
    at processTicksAndRejections (internal/process/task_queues.js:83:17)
Command: out/Release/node /Users/luigi/dev/node/test/parallel/test-tls-sni-option.js
=== release test-tls-sni-option ===                   
Path: parallel/test-tls-sni-option
events.js:173
      throw er; // Unhandled 'error' event
      ^

Error: read ECONNRESET
    at TLSWrap.onStreamRead (internal/stream_base_commons.js:183:27)
Emitted 'error' event at:
    at emitErrorNT (internal/streams/destroy.js:91:8)
    at emitErrorAndCloseNT (internal/streams/destroy.js:59:3)
    at processTicksAndRejections (internal/process/task_queues.js:83:17)
Command: out/Release/node /Users/luigi/dev/node/test/parallel/test-tls-sni-option.js
=== release test-tls-sni-option ===                   
Path: parallel/test-tls-sni-option
events.js:173
      throw er; // Unhandled 'error' event
      ^

Error: read ECONNRESET
    at TLSWrap.onStreamRead (internal/stream_base_commons.js:183:27)
Emitted 'error' event at:
    at emitErrorNT (internal/streams/destroy.js:91:8)
    at emitErrorAndCloseNT (internal/streams/destroy.js:59:3)
    at processTicksAndRejections (internal/process/task_queues.js:83:17)
Command: out/Release/node /Users/luigi/dev/node/test/parallel/test-tls-sni-option.js
=== release test-tls-sni-option ===                   
Path: parallel/test-tls-sni-option
events.js:173
      throw er; // Unhandled 'error' event
      ^

Error: read ECONNRESET
    at TLSWrap.onStreamRead (internal/stream_base_commons.js:183:27)
Emitted 'error' event at:
    at emitErrorNT (internal/streams/destroy.js:91:8)
    at emitErrorAndCloseNT (internal/streams/destroy.js:59:3)
    at processTicksAndRejections (internal/process/task_queues.js:83:17)
Command: out/Release/node /Users/luigi/dev/node/test/parallel/test-tls-sni-option.js
=== release test-tls-sni-option ===                   
Path: parallel/test-tls-sni-option
events.js:173
      throw er; // Unhandled 'error' event
      ^

Error: read ECONNRESET
    at TLSWrap.onStreamRead (internal/stream_base_commons.js:183:27)
Emitted 'error' event at:
    at emitErrorNT (internal/streams/destroy.js:91:8)
    at emitErrorAndCloseNT (internal/streams/destroy.js:59:3)
    at processTicksAndRejections (internal/process/task_queues.js:83:17)
Command: out/Release/node /Users/luigi/dev/node/test/parallel/test-tls-sni-option.js
=== release test-tls-sni-option ===                   
Path: parallel/test-tls-sni-option
events.js:173
      throw er; // Unhandled 'error' event
      ^

Error: read ECONNRESET
    at TLSWrap.onStreamRead (internal/stream_base_commons.js:183:27)
Emitted 'error' event at:
    at emitErrorNT (internal/streams/destroy.js:91:8)
    at emitErrorAndCloseNT (internal/streams/destroy.js:59:3)
    at processTicksAndRejections (internal/process/task_queues.js:83:17)
Command: out/Release/node /Users/luigi/dev/node/test/parallel/test-tls-sni-option.js
=== release test-tls-sni-option ===                   
Path: parallel/test-tls-sni-option
events.js:173
      throw er; // Unhandled 'error' event
      ^

Error: read ECONNRESET
    at TLSWrap.onStreamRead (internal/stream_base_commons.js:183:27)
Emitted 'error' event at:
    at emitErrorNT (internal/streams/destroy.js:91:8)
    at emitErrorAndCloseNT (internal/streams/destroy.js:59:3)
    at processTicksAndRejections (internal/process/task_queues.js:83:17)
Command: out/Release/node /Users/luigi/dev/node/test/parallel/test-tls-sni-option.js
=== release test-tls-sni-option ===                   
Path: parallel/test-tls-sni-option
events.js:173
      throw er; // Unhandled 'error' event
      ^

Error: read ECONNRESET
    at TLSWrap.onStreamRead (internal/stream_base_commons.js:183:27)
Emitted 'error' event at:
    at emitErrorNT (internal/streams/destroy.js:91:8)
    at emitErrorAndCloseNT (internal/streams/destroy.js:59:3)
    at processTicksAndRejections (internal/process/task_queues.js:83:17)
Command: out/Release/node /Users/luigi/dev/node/test/parallel/test-tls-sni-option.js
=== release test-tls-sni-option ===                   
Path: parallel/test-tls-sni-option
events.js:173
      throw er; // Unhandled 'error' event
      ^

Error: read ECONNRESET
    at TLSWrap.onStreamRead (internal/stream_base_commons.js:183:27)
Emitted 'error' event at:
    at emitErrorNT (internal/streams/destroy.js:91:8)
    at emitErrorAndCloseNT (internal/streams/destroy.js:59:3)
    at processTicksAndRejections (internal/process/task_queues.js:83:17)
Command: out/Release/node /Users/luigi/dev/node/test/parallel/test-tls-sni-option.js
=== release test-tls-sni-option ===                   
Path: parallel/test-tls-sni-option
events.js:173
      throw er; // Unhandled 'error' event
      ^

Error: read ECONNRESET
    at TLSWrap.onStreamRead (internal/stream_base_commons.js:183:27)
Emitted 'error' event at:
    at emitErrorNT (internal/streams/destroy.js:91:8)
    at emitErrorAndCloseNT (internal/streams/destroy.js:59:3)
    at processTicksAndRejections (internal/process/task_queues.js:83:17)
Command: out/Release/node /Users/luigi/dev/node/test/parallel/test-tls-sni-option.js
=== release test-tls-sni-option ===                   
Path: parallel/test-tls-sni-option
events.js:173
      throw er; // Unhandled 'error' event
      ^

Error: read ECONNRESET
    at TLSWrap.onStreamRead (internal/stream_base_commons.js:183:27)
Emitted 'error' event at:
    at emitErrorNT (internal/streams/destroy.js:91:8)
    at emitErrorAndCloseNT (internal/streams/destroy.js:59:3)
    at processTicksAndRejections (internal/process/task_queues.js:83:17)
Command: out/Release/node /Users/luigi/dev/node/test/parallel/test-tls-sni-option.js
=== release test-tls-sni-option ===                   
Path: parallel/test-tls-sni-option
events.js:173
      throw er; // Unhandled 'error' event
      ^

Error: read ECONNRESET
    at TLSWrap.onStreamRead (internal/stream_base_commons.js:183:27)
Emitted 'error' event at:
    at emitErrorNT (internal/streams/destroy.js:91:8)
    at emitErrorAndCloseNT (internal/streams/destroy.js:59:3)
    at processTicksAndRejections (internal/process/task_queues.js:83:17)
Command: out/Release/node /Users/luigi/dev/node/test/parallel/test-tls-sni-option.js
[00:17|% 100|+ 986|-  14]: Done

Let .end() propogate from client, to server, and back, before considering the test complete. Also, remove the test vector and exit handling in favour of running all the tests in parallel and using common.must/mustNotCall().

nodejs-github-bot · 2019-04-24T16:40:57Z

CI: https://ci.nodejs.org/job/node-test-pull-request/22689/

sam-github · 2019-04-24T16:42:02Z

@lpinca OK, so the graceful end is necessary, I reverted. the tools/test.py --repeat now passes for me. PTAL

lpinca · 2019-04-24T16:48:37Z

It works on my machine.

sam-github · 2019-04-25T17:11:19Z

Landed in 6bbb9eb

Let .end() propogate from client, to server, and back, before considering the test complete. Also, remove the test vector and exit handling in favour of running all the tests in parallel and using common.must/mustNotCall(). PR-URL: #27300 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>

Refs: nodejs#27300

Let .end() propogate from client, to server, and back, before considering the test complete. Also, remove the test vector and exit handling in favour of running all the tests in parallel and using common.must/mustNotCall(). PR-URL: #27300 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>

Refs: nodejs#27300 PR-URL: nodejs#27425 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>

- Run all tests in parallel. - Move `socket.end()` call to client. - Use `common.mustCall()` and `common.mustNotCall()`. Fixes: nodejs#27219 Refs: nodejs#27300

- Run all tests in parallel. - Move `socket.end()` call to client. - Use `common.mustCall()` and `common.mustNotCall()`. Fixes: nodejs#27219 Refs: nodejs#27300 PR-URL: nodejs#27426 Reviewed-By: Sam Roberts <vieuxtech@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>

Refs: #27300 PR-URL: #27425 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>

- Run all tests in parallel. - Move `socket.end()` call to client. - Use `common.mustCall()` and `common.mustNotCall()`. Fixes: #27219 Refs: #27300 PR-URL: #27426 Reviewed-By: Sam Roberts <vieuxtech@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>

nodejs-github-bot added the test Issues and PRs related to the tests. label Apr 18, 2019

sam-github added the wip Issues and PRs that are still a work in progress. label Apr 19, 2019

sam-github force-pushed the deflake-tls-sni-option branch from 006fbb1 to a8b43f2 Compare April 22, 2019 23:21

sam-github removed the wip Issues and PRs that are still a work in progress. label Apr 23, 2019

sam-github marked this pull request as ready for review April 23, 2019 01:54

sam-github force-pushed the deflake-tls-sni-option branch 2 times, most recently from 8e00546 to d4315ba Compare April 23, 2019 15:28

sam-github mentioned this pull request Apr 23, 2019

Investigate flaky parallel/test-tls-sni-option #26910

Closed

sam-github force-pushed the deflake-tls-sni-option branch 2 times, most recently from 237353f to 49accf1 Compare April 23, 2019 20:57

test: rework to remove flakiness, and be parallel

fc8a3d9

Let .end() propogate from client, to server, and back, before considering the test complete. Also, remove the test vector and exit handling in favour of running all the tests in parallel and using common.must/mustNotCall().

sam-github force-pushed the deflake-tls-sni-option branch from 49accf1 to fc8a3d9 Compare April 24, 2019 16:40

lpinca approved these changes Apr 24, 2019

View reviewed changes

gireeshpunathil approved these changes Apr 25, 2019

View reviewed changes

sam-github closed this Apr 25, 2019

sam-github deleted the deflake-tls-sni-option branch April 25, 2019 17:11

lpinca added a commit to lpinca/node that referenced this pull request Apr 26, 2019

test: remove flaky designation for test-tls-sni-option

11c4bd3

Refs: nodejs#27300

lpinca mentioned this pull request Apr 26, 2019

test: remove flaky designation for test-tls-sni-option #27425

Closed

2 tasks

lpinca mentioned this pull request Apr 26, 2019

test: refactor and deflake test-tls-sni-server-client #27426

Closed

2 tasks

targos mentioned this pull request Apr 27, 2019

v12.1.0 proposal #27440

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

test: deflake test-tls-sni-option #27300

test: deflake test-tls-sni-option #27300

sam-github commented Apr 18, 2019 •

edited

Loading

nodejs-github-bot commented Apr 18, 2019

sam-github commented Apr 19, 2019

nodejs-github-bot commented Apr 23, 2019

nodejs-github-bot commented Apr 23, 2019

sam-github commented Apr 23, 2019

lpinca commented Apr 24, 2019

nodejs-github-bot commented Apr 24, 2019

sam-github commented Apr 24, 2019

lpinca commented Apr 24, 2019

sam-github commented Apr 25, 2019

test: deflake test-tls-sni-option #27300

test: deflake test-tls-sni-option #27300

Conversation

sam-github commented Apr 18, 2019 • edited Loading

Checklist

nodejs-github-bot commented Apr 18, 2019

sam-github commented Apr 19, 2019

nodejs-github-bot commented Apr 23, 2019

nodejs-github-bot commented Apr 23, 2019

sam-github commented Apr 23, 2019

lpinca commented Apr 24, 2019

nodejs-github-bot commented Apr 24, 2019

sam-github commented Apr 24, 2019

lpinca commented Apr 24, 2019

sam-github commented Apr 25, 2019

sam-github commented Apr 18, 2019 •

edited

Loading