Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: improve test-async-hooks-http-parser-destroy #27319

Closed
wants to merge 4 commits into from

Commits on May 3, 2019

  1. test: improve test-async-hooks-http-parser-destroy

    Improve reporting in test-async-hooks-http-parser-destroy when failing.
    
    Before, failures looked like this (edited slightly to conform to our
    commit message 72-char line length restriction):
    
        The expression evaluated to a falsy value:
        assert.ok(destroyedIds.indexOf(createdAsyncId) >= 0)
    
    Now, you get a slightly better idea of what's up. (Is it missing one ID?
    More than one? All of them?):
    
        AssertionError [ERR_ASSERTION]: Expected values to be strictly deep-equal:
        + actual - expected ... Lines skipped
    
          [
            156,
        ...
            757,
        -   761,
            765
          ]
    Trott committed May 3, 2019
    Configuration menu
    Copy the full SHA
    2bc9310 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    d478ae8 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    9e5a8f4 View commit details
    Browse the repository at this point in the history

Commits on May 4, 2019

  1. Configuration menu
    Copy the full SHA
    4827486 View commit details
    Browse the repository at this point in the history