Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

process: improve nextTick performance #27347

Closed
wants to merge 1 commit into from
Closed

process: improve nextTick performance #27347

wants to merge 1 commit into from

Conversation

apapirovski
Copy link
Member

@apapirovski apapirovski commented Apr 22, 2019 •
edited
Loading

  • No longer use symbols for asyncId & triggerAsyncId. This borrows from the seemingly abandoned PR at process: improve nextTick performance #25461 by @mscdex. (Credit provided in the commit but happy to also remove this portion of the code.)
  • No longer check process.exiting on each tick add.
  • Cleaner emitDestroy with try/finally.
  • No longer use Reflect.apply since it's slower.

CI: https://ci.nodejs.org/job/node-test-pull-request/22633/

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines

@nodejs-github-bot
Copy link
Collaborator

Lite-CI: https://ci.nodejs.org/job/node-test-pull-request-lite-pipeline/3324

@nodejs-github-bot nodejs-github-bot added the process Issues and PRs related to the process subsystem. label Apr 22, 2019
@nodejs-github-bot

This comment has been minimized.

Sign in to view
@apapirovski apapirovski force-pushed the patch-next-tick-perf branch from 4e37387 to f5e1032 Compare April 22, 2019 18:57
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/22633/

@mscdex
Copy link
Contributor

mscdex commented Apr 22, 2019 •
edited
Loading

FWIW my PR for improving nextTick performance isn't abandoned, I just haven't had time to revisit it yet.

Also, this PR is now exposing asyncId and triggerAsyncId on the object passed to the hook(s) more directly. I think we should be hiding those sorts of things from hooks, as I believe that may be why Symbols were used in the first place.

@apapirovski
Copy link
Member Author

FWIW my PR for improving nextTick performance isn't abandoned, I just haven't had time to revisit it yet.

👍 will remove from here.

@apapirovski
process: improve nextTick performance
4d82fd8 
No longer check process.exiting on each tick add.
Cleaner emitDestroy with try/finally.
No longer use Reflect.apply since it's slower.
@apapirovski apapirovski force-pushed the patch-next-tick-perf branch from f5e1032 to 4d82fd8 Compare April 22, 2019 19:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
process Issues and PRs related to the process subsystem.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@apapirovski @nodejs-github-bot @mscdex