test: replace HTTPPARSER by new resource names #27372
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodejs-github-bot
added
async_hooks
The async resource `HTTPPARSER` has been replaced by `HTTPINCOMINGMESSAGE` and `HTTPCLIENTREQUEST` but some tests have not been adapted. As test test-graph.http.js has not failed even it asserted on ´HTTPPARSER` I improved `verify-graph` and adapted the asserts in test-graph.tls-write which failed because of the stricter check. Refs: #25094
Trott
reviewed
Apr 23, 2019
| @@ -16,7 +16,7 @@ const createdIds = []; | |||
| const destroyedIds = []; | |||
| async_hooks.createHook({ | |||
| init: common.mustCallAtLeast((asyncId, type) => { | |||
| if (type === 'HTTPPARSER') { | |||
| if (type === 'HTTPINCOMINGMESSAGE' || type === 'HTTPCLIENTREQUEST') { | |||
There was a problem hiding this comment.
Does HTTPCLIENTREQUEST ever actually happen here? My messing around with this for another PR has that never showing up.
There was a problem hiding this comment.
There was a problem hiding this comment.
Just tried and it seems HTTPCLIENTREQUEST is never emitted. This is for sure a bug.
BridgeAR
approved these changes
Apr 24, 2019
|
I think the CI fails on freebsd are unrelated. |
|
superseded by #27477 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The async resource
HTTPPARSERhas been replaced byHTTPINCOMINGMESSAGEandHTTPCLIENTREQUESTbut some tests havenot been adapted.
As test test-graph.http.js has not failed even it asserted on
HTTPPARSERI improvedverify-graphand adapted the asserts intest-graph.tls-write which failed because of the stricter check.
Refs: #25094
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes