Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deps: V8: cherry-pick 5d0cf6b #27423

Closed
wants to merge 1 commit into from

Commits on Apr 26, 2019

  1. deps: V8: cherry-pick 5d0cf6b

    Original commit message:
    
        [snapshot] Use Handle to track name in `CodeSerializer::Deserialize`
    
        The `Script::InitLineEnds(Handle<Script>(script, isolate));` line
        may lead to objects being moved around on the heap, so it’s necessary
        to use a `Handle` to track that.
    
        This was causing crashes in Node.js in Debug mode when using the
        code cache in combination with the CPU profiler.
    
        Refs: nodejs#27307
        Change-Id: I392b4c00c6ebad44753f87fcbf2e3278ea7799a6
        Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1575698
        Reviewed-by: Jakob Gruber <jgruber@chromium.org>
        Reviewed-by: Peter Marshall <petermarshall@chromium.org>
        Commit-Queue: Peter Marshall <petermarshall@chromium.org>
        Cr-Commit-Position: refs/heads/master@{#61036}
    
    Refs: v8/v8@5d0cf6b
    joyeecheung committed Apr 26, 2019
    Configuration menu
    Copy the full SHA
    6388fb0 View commit details
    Browse the repository at this point in the history