Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: add mustCall to test-dgram-implicit-bind test #27452

Closed
wants to merge 1 commit into from
Closed

test: add mustCall to test-dgram-implicit-bind test #27452

wants to merge 1 commit into from

Conversation

yuanchenxi95
Copy link
Contributor

@yuanchenxi95 yuanchenxi95 commented Apr 28, 2019 •
edited by joyeecheung
Loading

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines

@nodejs-github-bot nodejs-github-bot added the test Issues and PRs related to the tests. label Apr 28, 2019
@joyeecheung joyeecheung added the code-and-learn Issues related to the Code-and-Learn events and PRs submitted during the events. label Apr 28, 2019
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/22757/

@gireeshpunathil gireeshpunathil added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Apr 28, 2019
@gireeshpunathil
Copy link
Member

please leave 👍 to fast-track

cjihrig
cjihrig approved these changes Apr 28, 2019
View reviewed changes
Copy link
Contributor

@cjihrig cjihrig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think this is necessary, but the code LGTM.

@oyyd oyyd added the fast-track PRs that do not need to wait for 48 hours to land. label Apr 29, 2019
@oyyd
Copy link
Contributor

oyyd commented Apr 29, 2019

Landed in c3d4933, thanks!

You can visit https://www.nodetodo.org/next-steps/ for more ideas to contribute.

@oyyd oyyd closed this Apr 29, 2019
pull bot pushed a commit to SimenB/node that referenced this pull request Apr 29, 2019
@yuanchenxi95 @oyyd
test: add mustCall to test-dgram-implicit-bind.js
c3d4933 
PR-URL: nodejs#27452
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Yorkie Liu <yorkiefixer@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com>
targos pushed a commit that referenced this pull request Apr 29, 2019
@yuanchenxi95 @targos
test: add mustCall to test-dgram-implicit-bind.js
4b9d109 
PR-URL: #27452
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Yorkie Liu <yorkiefixer@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com>
@targos targos mentioned this pull request May 6, 2019
Merged
This was referenced May 7, 2019
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ZYSzys ZYSzys ZYSzys approved these changes

@gireeshpunathil gireeshpunathil gireeshpunathil approved these changes

@joyeecheung joyeecheung joyeecheung approved these changes

@cjihrig cjihrig cjihrig approved these changes

@yorkie yorkie yorkie approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. code-and-learn Issues related to the Code-and-Learn events and PRs submitted during the events. fast-track PRs that do not need to wait for 48 hours to land. test Issues and PRs related to the tests.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@yuanchenxi95 @nodejs-github-bot @gireeshpunathil @oyyd @yorkie @cjihrig @joyeecheung @ZYSzys