Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: add mustCall to test-net-after-close test #27459

Closed
wants to merge 1 commit into from
Closed

test: add mustCall to test-net-after-close test #27459

wants to merge 1 commit into from

Conversation

xuqinggang
Copy link

test: add mustCall to test-net-after-close test

@nodejs-github-bot nodejs-github-bot added the test Issues and PRs related to the tests. label Apr 28, 2019
@ZYSzys ZYSzys added the code-and-learn Issues related to the Code-and-Learn events and PRs submitted during the events. label Apr 28, 2019
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/22767/

@gireeshpunathil
Copy link
Member

please leave 👍 to fast track

cjihrig
cjihrig approved these changes Apr 28, 2019
View reviewed changes
Copy link
Contributor

@cjihrig cjihrig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but the mustCall() isn't necessary.

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/22789/

@oyyd oyyd added the fast-track PRs that do not need to wait for 48 hours to land. label Apr 29, 2019
@Trott
Copy link
Member

Trott commented Apr 29, 2019

Landed in 095bd56

@Trott Trott closed this Apr 29, 2019
Trott pushed a commit to Trott/io.js that referenced this pull request Apr 29, 2019
@Trott
test: add mustCall to test-net-after-close test
095bd56 
PR-URL: nodejs#27459
Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com>
Reviewed-By: Weijia Wang <starkwang@126.com>
Reviewed-By: Yorkie Liu <yorkiefixer@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Anto Aravinth <anto.aravinth.cse@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
@Trott
Copy link
Member

Trott commented Apr 29, 2019

Thanks for the contribution! 🎉

(If you're interested in other possible contributions to Node.js but don't have a good idea of where to start looking, some ideas are posted at https://www.nodetodo.org/next-steps/.)

targos pushed a commit that referenced this pull request Apr 30, 2019
@targos
test: add mustCall to test-net-after-close test
eeab007 
PR-URL: #27459
Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com>
Reviewed-By: Weijia Wang <starkwang@126.com>
Reviewed-By: Yorkie Liu <yorkiefixer@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Anto Aravinth <anto.aravinth.cse@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
@targos targos mentioned this pull request May 6, 2019
Merged
This was referenced May 7, 2019
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ZYSzys ZYSzys ZYSzys approved these changes

@starkwang starkwang starkwang approved these changes

@gireeshpunathil gireeshpunathil gireeshpunathil approved these changes

@cjihrig cjihrig cjihrig approved these changes

@yorkie yorkie yorkie approved these changes

@antsmartian antsmartian antsmartian approved these changes

@Trott Trott Trott approved these changes

Assignees
No one assigned
Labels
code-and-learn Issues related to the Code-and-Learn events and PRs submitted during the events. fast-track PRs that do not need to wait for 48 hours to land. test Issues and PRs related to the tests.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
10 participants
@xuqinggang @nodejs-github-bot @gireeshpunathil @Trott @antsmartian @yorkie @cjihrig @starkwang @ZYSzys @oyyd