-
Notifications
You must be signed in to change notification settings - Fork 29.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test: fs internal util preprocessSymlinkDestination() function #27468
test: fs internal util preprocessSymlinkDestination() function #27468
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think you an even assert the exact return values of the function, instead of applying regexes here?
(Either way, this LGTM, and thank you!)
@addaleax, |
@rpgeeganage Yeah, it’s not a blocking review comment that needs to be addressed in order for this to land. :) |
@addaleax , |
Landed in 64284aa |
PR-URL: nodejs#27468 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Masashi Hirano <shisama07@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
PR-URL: #27468 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Masashi Hirano <shisama07@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Unit tests for
preprocessSymlinkDestination()
function in'internal/fs/utils'
.These tests are without any monkey-patching for the platform.
Checklist
make -j4 test
(UNIX), orvcbuild test
(Windows) passes