-
Notifications
You must be signed in to change notification settings - Fork 30.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
doc: add the missing deprecated method 'tmpDir()' #27473
Conversation
Does it make sense to document it now that is deprecated? I mean it was not documented, why should we do it now? |
@lpinca:So you mean this wasn't documented on purpose? |
I don't know but I think it's better to keep it undocumented. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fine with me to document it I suppose, but please move it below tmpdir
so CTRL-F will find the correct function first.
'tmpDir()' is first introduced in v0.7.11 (https://github.com/nodejs/node/releases/tag/v0.7.11), and then changed from 'tmpDir()' to 'tmpdir()' since v0.9.9 (3fe6aba). Considering this is a deprecated method, add it as usual in the doc.
@silverwind:Thanks! I've corrected that, please have a review. |
Thank you for the contribution, @ghost, and sorry about the long inactivity! I don't think we should add new documentation for a previously undocumented, deprecated API. Since node 8, |
'tmpDir()' is first introduced in v0.7.11 (https://github.com/nodejs/node/releases/tag/v0.7.11), and then changed from 'tmpDir()' to 'tmpdir()' since v0.9.9 (3fe6aba).
Considering this is a deprecated method, add it as usual in the doc.
make -j4 test
(UNIX), orvcbuild test
(Windows) passes