Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

src: refactor V8ProfilerConnection to be more reusable #27475

Closed
wants to merge 3 commits into from

Commits on Apr 29, 2019

  1. src: refactor profile initialization

    - Process and store --cpu-prof-dir and --cpu-prof-name during
      Environment creation
    - Start profilers in on `profiler::StartProfilers()`
    joyeecheung committed Apr 29, 2019
    Configuration menu
    Copy the full SHA
    f1ac159 View commit details
    Browse the repository at this point in the history
  2. src: refactor V8ProfilerConnection to be more reusable

    Now the subclasses only need to override methods to
    
    - Get the profile node from the profiler response message object
    - Return the directory and file path
    
    And the V8ProfilerConnection() would handle the rest of profile
    serialization and message parsing. This makes it easier to
    add other types of profiles in the future.
    joyeecheung committed Apr 29, 2019
    Configuration menu
    Copy the full SHA
    026d821 View commit details
    Browse the repository at this point in the history

Commits on May 1, 2019

  1. Configuration menu
    Copy the full SHA
    80f8e65 View commit details
    Browse the repository at this point in the history