-
Notifications
You must be signed in to change notification settings - Fork 29.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test: vm module error thrown when breakOnSigint is not a boolean evaluate() #27503
Closed
rpgeeganage
wants to merge
2
commits into
nodejs:master
from
rpgeeganage:test_vm_evaluate_invalid_option
Closed
test: vm module error thrown when breakOnSigint is not a boolean evaluate() #27503
rpgeeganage
wants to merge
2
commits into
nodejs:master
from
rpgeeganage:test_vm_evaluate_invalid_option
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
addaleax
approved these changes
May 1, 2019
addaleax
added
author ready
PRs that have at least one approval, no pending requests for changes, and a CI started.
esm
Issues and PRs related to the ECMAScript Modules implementation.
vm
Issues and PRs related to the vm subsystem.
labels
May 1, 2019
Trott
reviewed
May 2, 2019
Trott
approved these changes
May 2, 2019
ZYSzys
approved these changes
May 4, 2019
trivikr
approved these changes
May 6, 2019
@trivikr , thanks for approving the PR. |
@rpgeeganage Thank you! I'm happy that the video was helpful 😄 |
Landed in 8b78fbd 🎉 |
ZYSzys
pushed a commit
that referenced
this pull request
May 11, 2019
PR-URL: #27503 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
targos
pushed a commit
that referenced
this pull request
May 13, 2019
PR-URL: #27503 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
author ready
PRs that have at least one approval, no pending requests for changes, and a CI started.
esm
Issues and PRs related to the ECMAScript Modules implementation.
test
Issues and PRs related to the tests.
vm
Issues and PRs related to the vm subsystem.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This unit test is to assert the error thrown when
none boolean
value passed asbreakOnSigint
attribute to theevaluate()
function.Checklist
make -j4 test
(UNIX), orvcbuild test
(Windows) passes