doc: add missing --trace in man page
#27510
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
addaleax
reviewed
May 1, 2019
| @@ -282,6 +282,9 @@ or servers. | |||
| Set default minVersion to 'TLSv1.3'. Use to disable support for TLSv1.2 in | |||
| favour of TLSv1.3, which is more secure. | |||
| . | |||
| .It Fl -trace | |||
| Print the default trace on standard output. | |||
There was a problem hiding this comment.
We generally document only very few V8 options – if you feel that this is important, that’s okay, but can you update the description to explain a bit more on what this does? E.g. the text from node --v8-options is trace function calls, which doesn’t say much either, but is a bit more explicit than default trace.
|
Thanks, I wasn't aware of the existence of those v8 parameters.
One alternative is to list important v8 parameters and points the reader to the appropriate doc: see
#27528
This would also solve the problem 'man node' >> 'search --trace'
|
|
If the reasons quoted in #27528 is still valid, this PR can be closed. |
BridgeAR
force-pushed
the
master
branch
2 times, most recently
from
8ae28ff
to
2935f72
Compare
|
Looks like this can be closed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a documentation pull-request to improve the man page.