util: inspect constructor closer #27522
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment has been minimized.
This comment has been minimized.
nodejs-github-bot
added
c++
addaleax
approved these changes
May 1, 2019
BridgeAR
force-pushed
the
inspect-constructor-name-closer
branch
from
8a49467
to
3b22ce9
Compare
BridgeAR
added
the
author ready
This comment has been minimized.
This comment has been minimized.
targos
approved these changes
May 2, 2019
Trott
approved these changes
May 2, 2019
This comment has been minimized.
This comment has been minimized.
This adds an extra check to `util.inspect` to closer inspect object constructors in case there's not much other information about the constructor.
BridgeAR
force-pushed
the
inspect-constructor-name-closer
branch
from
3b22ce9
to
d047763
Compare
This comment has been minimized.
This comment has been minimized.
ZYSzys
approved these changes
May 4, 2019
|
Landed in 7910b02 🎉. |
ZYSzys
pushed a commit
that referenced
this pull request
May 4, 2019
This adds an extra check to `util.inspect` to closer inspect object constructors in case there's not much other information about the constructor. PR-URL: #27522 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com>
4 tasks
|
Backport to v12.x is blocked on #27227. |
BridgeAR
added a commit
to BridgeAR/node
that referenced
this pull request
May 5, 2019
This adds an extra check to `util.inspect` to closer inspect object constructors in case there's not much other information about the constructor. PR-URL: nodejs#27522 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com>
targos
pushed a commit
that referenced
this pull request
May 6, 2019
This adds an extra check to `util.inspect` to closer inspect object constructors in case there's not much other information about the constructor. PR-URL: #27522 Backport-PR-URL: #27570 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com>
Merged
This was referenced May 7, 2019
This was referenced May 7, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds an extra check to
util.inspectto closer inspect objectconstructors in case there's not much other information about the
constructor.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes