-
Notifications
You must be signed in to change notification settings - Fork 29.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test: refactor test-tls-enable-trace-cli.js #27553
Conversation
Its possible that pumping some data through the connections before the |
The following error is happening in the child process:
|
Most of the ways that can happen look like BIO_write() not writing everything it was asked to, and it might have registered an error when it failed. Printing the err.opensslErrorStack might give some more info here. |
Landed in 9a174db. |
PR-URL: #27553 Reviewed-By: Sam Roberts <vieuxtech@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>
PR-URL: #27553 Reviewed-By: Sam Roberts <vieuxtech@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>
This test appears to be flakey on Unix. I'm not entirely sure why, but I think it may be related to the additional piping of the child process stderr (although this test is mostly a copy of another test that isn't exhibiting problems). This commit simplifies the test a bit.
Some preliminary testing seems promising:
If the stress test comes back green, I'd recommend fast tracking this.
Checklist
make -j4 test
(UNIX), orvcbuild test
(Windows) passes