Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: refactor test-tls-enable-trace-cli.js #27553

Closed
wants to merge 3 commits into from
Closed

Conversation

cjihrig
Copy link
Contributor

@cjihrig cjihrig commented May 3, 2019

This test appears to be flakey on Unix. I'm not entirely sure why, but I think it may be related to the additional piping of the child process stderr (although this test is mostly a copy of another test that isn't exhibiting problems). This commit simplifies the test a bit.

Some preliminary testing seems promising:

If the stress test comes back green, I'd recommend fast tracking this.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • commit message follows commit guidelines

@nodejs-github-bot
Copy link
Collaborator

@nodejs-github-bot nodejs-github-bot added the test Issues and PRs related to the tests. label May 3, 2019
@nodejs-github-bot
Copy link
Collaborator

@sam-github
Copy link
Contributor

Its possible that pumping some data through the connections before the cleanup() would fix this, perhaps the connection is closing too early, which is a common source of races. The server side is piping the req to the rsp, so the client could just do something like const c = pair.client.conn; c.end('x'); c.on('end', cleanup); instead of the return cleanup().

@cjihrig
Copy link
Contributor Author

cjihrig commented May 4, 2019

The following error is happening in the child process:

AssertionError [ERR_ASSERTION]: ifError got unwanted exception: 140480012626824:error:09072007:PEM routines:PEM_write_bio:BUF lib:../deps/openssl/openssl/crypto/pem/pem_lib.c:658:
140480012626824:error:09072007:PEM routines:PEM_write_bio:BUF lib:../deps/openssl/openssl/crypto/pem/pem_lib.c:658:

@sam-github
Copy link
Contributor

Most of the ways that can happen look like BIO_write() not writing everything it was asked to, and it might have registered an error when it failed. Printing the err.opensslErrorStack might give some more info here.

@nodejs-github-bot
Copy link
Collaborator

@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented May 7, 2019

@danbev
Copy link
Contributor

danbev commented May 8, 2019

Landed in 9a174db.

@danbev danbev closed this May 8, 2019
danbev pushed a commit that referenced this pull request May 8, 2019
PR-URL: #27553
Reviewed-By: Sam Roberts <vieuxtech@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
@cjihrig cjihrig deleted the test branch May 8, 2019 17:07
targos pushed a commit that referenced this pull request May 9, 2019
PR-URL: #27553
Reviewed-By: Sam Roberts <vieuxtech@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
@BridgeAR BridgeAR mentioned this pull request May 21, 2019
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
test Issues and PRs related to the tests.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants