Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

async_hooks: don't reuse resource in HttpAgent #27581

Closed
wants to merge 2 commits into from
Closed

async_hooks: don't reuse resource in HttpAgent #27581

wants to merge 2 commits into from

Commits on May 6, 2019

  1. async_hooks: don't reuse resource in HttpAgent 

    As discussed in nodejs/diagnostics#248,
nodejs#21313 and
https://docs.google.com/document/d/1g8OrG5lMIUhRn1zbkutgY83MiTSMx-0NHDs8Bf-nXxM/preview
reusing the resource object is a blocker for landing a resource based
async hooks API and get rid of the promise destroy hook.

This PR ensures that HttpAgent uses the a new resource object in case
the socket handle gets reused.
    @Flarna
    Flarna committed May 6, 2019
    Configuration menu
    Copy the full SHA
    62fc777 View commit details
    Browse the repository at this point in the history

Commits on May 15, 2019

  1. fixup: correct typo

    @Flarna
    Flarna committed May 15, 2019
    Configuration menu
    Copy the full SHA
    ef62c5a View commit details
    Browse the repository at this point in the history