module: improve resolve paths validation #27613
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
CI: https://ci.nodejs.org/job/node-test-pull-request/23016/ EDIT(cjihrig): CI was yellow. |
|
Ping for reviews |
targos
approved these changes
May 10, 2019
This commit adds input validation to require.resolve()'s paths option. Prior to this change, passing in a non-array value lead to a misleading 'module not found' error. Refs: nodejs#27583
|
CI: https://ci.nodejs.org/job/node-test-pull-request/23032/ EDIT(cjihrig): CI was yellow. |
Trott
added
the
author ready
Trott
approved these changes
May 10, 2019
jasnell
approved these changes
May 10, 2019
|
Landed in a608caa |
Trott
pushed a commit
to Trott/io.js
that referenced
this pull request
May 10, 2019
This commit adds input validation to require.resolve()'s paths option. Prior to this change, passing in a non-array value lead to a misleading 'module not found' error. Refs: nodejs#27583 PR-URL: nodejs#27613 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
targos
pushed a commit
that referenced
this pull request
May 11, 2019
This commit adds input validation to require.resolve()'s paths option. Prior to this change, passing in a non-array value lead to a misleading 'module not found' error. Refs: #27583 PR-URL: #27613 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The first commit is just #27598, which I've included here just to avoid conflicts later.This PR adds input validation to
require.resolve()'spathsoption. Prior to this change, passing in a non-array value lead to a misleading 'module not found' error.Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes