Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tools: DRY isRequireCall() in lint rules #27680

Merged
merged 1 commit into from
May 15, 2019
Merged

Conversation

cjihrig
Copy link
Contributor

@cjihrig cjihrig commented May 13, 2019

This commit makes isRequireCall() a reusable utility function for core's custom ESLint rules.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • commit message follows commit guidelines

@nodejs-github-bot
Copy link
Collaborator

@nodejs-github-bot nodejs-github-bot added the tools Issues and PRs related to the tools directory. label May 13, 2019
@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented May 14, 2019

CI: https://ci.nodejs.org/job/node-test-pull-request/23115/

EDIT(cjihrig): CI was yellow.

@Trott Trott added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label May 14, 2019
This commit makes isRequireCall() a reusable utility
function for core's custom ESLint rules.

PR-URL: nodejs#27680
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com>
@cjihrig cjihrig merged commit 03d4353 into nodejs:master May 15, 2019
@cjihrig cjihrig deleted the lint-rules branch May 15, 2019 19:20
targos pushed a commit that referenced this pull request May 17, 2019
This commit makes isRequireCall() a reusable utility
function for core's custom ESLint rules.

PR-URL: #27680
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com>
@BridgeAR BridgeAR mentioned this pull request May 21, 2019
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. tools Issues and PRs related to the tools directory.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants