tools: DRY isString() in lint rules #27719
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit makes isString() a reusable utility function for core's custom ESLint rules.
BridgeAR
approved these changes
May 15, 2019
lpinca
approved these changes
May 15, 2019
shisama
approved these changes
May 16, 2019
|
CI: https://ci.nodejs.org/job/node-test-pull-request/23137/ EDIT(cjihrig): CI was green. |
shisama
added
the
author ready
ZYSzys
approved these changes
May 16, 2019
Trott
approved these changes
May 17, 2019
Trott
pushed a commit
to Trott/io.js
that referenced
this pull request
May 18, 2019
This commit makes isString() a reusable utility function for core's custom ESLint rules. PR-URL: nodejs#27719 Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Masashi Hirano <shisama07@gmail.com> Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>
|
Landed in af83b79 |
targos
pushed a commit
that referenced
this pull request
May 18, 2019
This commit makes isString() a reusable utility function for core's custom ESLint rules. PR-URL: #27719 Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Masashi Hirano <shisama07@gmail.com> Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit makes
isString()a reusable utility function for core's custom ESLint rules.Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes