assert: remove unreachable code #27786
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodejs-github-bot
added
the
assert
BridgeAR
approved these changes
May 20, 2019
Trott
added
the
author ready
cjihrig
approved these changes
May 20, 2019
ZYSzys
approved these changes
May 21, 2019
This comment has been minimized.
This comment has been minimized.
richardlau
approved these changes
May 21, 2019
This comment has been minimized.
This comment has been minimized.
trivikr
approved these changes
May 21, 2019
lpinca
approved these changes
May 21, 2019
jasnell
approved these changes
May 23, 2019
In lib/internal/assert/assertion_error.js, line 391 assures that `operator` is 'deepEqual' so there is no need to check the value of `operator` in a ternary on the next line (line 392). Remove the ternary.
Trott
force-pushed
the
assertion-error-unreachable
branch
from
48cf267
to
082b9e0
Compare
This comment has been minimized.
This comment has been minimized.
|
Landed in 99268b1 |
Trott
added a commit
to Trott/io.js
that referenced
this pull request
May 23, 2019
In lib/internal/assert/assertion_error.js, line 391 assures that `operator` is 'deepEqual' so there is no need to check the value of `operator` in a ternary on the next line (line 392). Remove the ternary. PR-URL: nodejs#27786 Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com> Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
targos
pushed a commit
that referenced
this pull request
May 28, 2019
In lib/internal/assert/assertion_error.js, line 391 assures that `operator` is 'deepEqual' so there is no need to check the value of `operator` in a ternary on the next line (line 392). Remove the ternary. PR-URL: #27786 Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com> Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In lib/internal/assert/assertion_error.js, line 391 assures that
operatoris 'deepEqual' so there is no need to check the value ofoperatorin a ternary on the next line (line 392). Remove the ternary.Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes