Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: increase debugging information on failure #27790

Closed
wants to merge 1 commit into from

Conversation

Trott
Copy link
Member

@Trott Trott commented May 21, 2019

Increase the information displayed when
test-child-process-pipe-dataflow.js fails.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines

Increase the information displayed when
test-child-process-pipe-dataflow.js fails.
@nodejs-github-bot

This comment has been minimized.

@nodejs-github-bot nodejs-github-bot added the test Issues and PRs related to the tests. label May 21, 2019
@nodejs-github-bot

This comment has been minimized.

@Trott
Copy link
Member Author

Trott commented May 21, 2019

Refs: #25988 (comment)

@Trott Trott added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label May 21, 2019
@nodejs-github-bot

This comment has been minimized.

@nodejs-github-bot
Copy link
Collaborator

@Trott
Copy link
Member Author

Trott commented May 23, 2019

Landed in cb16872

@Trott Trott closed this May 23, 2019
Trott added a commit to Trott/io.js that referenced this pull request May 23, 2019
Increase the information displayed when
test-child-process-pipe-dataflow.js fails.

PR-URL: nodejs#27790
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
targos pushed a commit that referenced this pull request May 28, 2019
Increase the information displayed when
test-child-process-pipe-dataflow.js fails.

PR-URL: #27790
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
@targos targos mentioned this pull request Jun 3, 2019
@Trott Trott deleted the moar-subprocess-info branch January 13, 2022 22:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. test Issues and PRs related to the tests.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants