test: increase debugging information on failure #27790
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Increase the information displayed when test-child-process-pipe-dataflow.js fails.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
|
Refs: #25988 (comment) |
gireeshpunathil
approved these changes
May 21, 2019
Trott
added
the
author ready
This comment has been minimized.
This comment has been minimized.
BridgeAR
approved these changes
May 21, 2019
addaleax
approved these changes
May 21, 2019
cjihrig
approved these changes
May 21, 2019
trivikr
approved these changes
May 21, 2019
|
Landed in cb16872 |
Trott
added a commit
to Trott/io.js
that referenced
this pull request
May 23, 2019
Increase the information displayed when test-child-process-pipe-dataflow.js fails. PR-URL: nodejs#27790 Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
targos
pushed a commit
that referenced
this pull request
May 28, 2019
Increase the information displayed when test-child-process-pipe-dataflow.js fails. PR-URL: #27790 Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Increase the information displayed when
test-child-process-pipe-dataflow.js fails.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes