Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v12.3.1 proposal #27814

Merged
merged 5 commits into from
May 22, 2019
Merged

v12.3.1 proposal #27814

merged 5 commits into from
May 22, 2019

Conversation

BridgeAR
Copy link
Member

@BridgeAR BridgeAR commented May 22, 2019

Notable changes

  • deps:
    • Fix handling of +0/-0 when constant field tracking is enabled (Michaël Zasso) #27792
    • Fix os.freemem() and os.totalmem correctness (cjihrig) #27718
  • src:
    • Fix v12.3.0 regression that prevents native addons from compiling #27804

Commits

  • [c478884725] - deps: V8: cherry-pick 94c87fe (Michaël Zasso) #27792
  • [aed74ccb4c] - deps: upgrade to libuv 1.29.1 (cjihrig) #27718
  • [7438a557af] - src: remove util-inl.h include in node.h (Anna Henningsen) #27804
  • [6f7005465a] - src, lib: take control of prepareStackTrace (Gus Caplan) #2392605465a)] - src, lib: take control of prepareStackTrace (Gus Caplan) #23926

@nodejs-github-bot
Copy link
Collaborator

@nodejs-github-bot nodejs-github-bot added libuv Issues and PRs related to the libuv dependency or the uv binding. meta Issues and PRs related to the general management of the project. v12.x labels May 22, 2019
BridgeAR added a commit that referenced this pull request May 22, 2019
This release fixes a regression introduced in v12.3.0 that prevents
native addons from compiling.

PR-URL: #27814
@BridgeAR
Copy link
Member Author

BridgeAR commented May 22, 2019

@nodejs/releasers I would like to include #27792 as well if you're fine to fast track that.

I guess I could highlight all commits as noteable changes but it's such a small release, it'll duplicate the complete changelog?

@nodejs-github-bot
Copy link
Collaborator

@BridgeAR
Copy link
Member Author

cjihrig and others added 3 commits May 22, 2019 10:18
Notable changes:

- uv_get_constrained_memory() has been added.
- A race condition in uv_async_send() has been fixed.
- uv_get_free_memory() and uv_get_total_memory() now read from
  /proc/meminfo, which should improve correctness when called
  from inside an lxc container.
- A failed assertion in uv_fs_poll_stop() has been fixed.
- A bug in MAC addresses for IP-aliases has been fixed.

Fixes: #27170
Fixes: #27493
PR-URL: #27718
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Ali Ijaz Sheikh <ofrobots@google.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Refs https://crbug.com/v8/7848

PR-URL: #23926
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
`node.h` may only include public APIs, which `util-inl.h` is not.
There does not seem to be any reason for including it, so remove it,
because otherwise native addon compilation is broken due to us not
shipping the `util-inl.h` header.

Refs: #27631
Fixes: #27803

PR-URL: #27804
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Sam Roberts <vieuxtech@gmail.com>
Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
@nodejs-github-bot
Copy link
Collaborator

@BridgeAR
Copy link
Member Author

I just included one more fix in this release and updated the release notes and the noteable changes. PTAL.

V8-CI https://ci.nodejs.org/job/node-test-commit-v8-linux/2297/
CITGM https://ci.nodejs.org/view/Node.js-citgm/job/citgm-smoker/1859/

targos and others added 2 commits May 22, 2019 14:29
Original commit message:

    [ic] Fix handling of +0/-0 when constant field tracking is enabled

    ... and ensure that runtime behaviour is in sync with the IC code.

    Bug: chromium:950747, v8:9113
    Change-Id: Ied66c9514cbe3a4d75fc71d4fc3b19ea1538f9b2
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1561319
    Reviewed-by: Toon Verwaest <verwaest@chromium.org>
    Commit-Queue: Igor Sheludko <ishell@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#60768}

PR-URL: #27792
Fixes: #27784
Refs: v8/v8@94c87fe
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Gus Caplan <me@gus.host>
Notable changes

* deps:
  * Fix handling of +0/-0 when constant field tracking is enabled
    (Michaël Zasso) #27792
  * Fix `os.freemem()` and `os.totalmem` correctness (cjihrig)
    #27718
* src:
  * Fix v12.3.0 regression that prevents native addons from compiling
    #27804

PR-URL: #27814
@cjihrig cjihrig mentioned this pull request May 22, 2019
@nodejs-github-bot
Copy link
Collaborator

@BridgeAR BridgeAR merged commit 2817fde into v12.x May 22, 2019
BridgeAR added a commit that referenced this pull request May 22, 2019
BridgeAR added a commit to BridgeAR/node that referenced this pull request May 22, 2019
Notable changes

* deps:
  * Fix handling of +0/-0 when constant field tracking is enabled
    (Michaël Zasso) nodejs#27792
  * Fix `os.freemem()` and `os.totalmem` correctness (cjihrig)
    nodejs#27718
* src:
  * Fix v12.3.0 regression that prevents native addons from compiling
    nodejs#27804

PR-URL: nodejs#27814
BridgeAR added a commit to BridgeAR/nodejs.org that referenced this pull request May 22, 2019
BridgeAR added a commit to nodejs/nodejs.org that referenced this pull request May 22, 2019
@targos targos deleted the v12.3.1-proposal branch June 4, 2019 14:09
@targos targos added release Issues and PRs related to Node.js releases. and removed libuv Issues and PRs related to the libuv dependency or the uv binding. meta Issues and PRs related to the general management of the project. labels Jun 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release Issues and PRs related to Node.js releases.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants