Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: roll WPT update for URL and harness #27822

Closed
wants to merge 3 commits into from

Conversation

joyeecheung
Copy link
Member

@joyeecheung joyeecheung commented May 22, 2019

I have another batch of patches for encoding tests, but would like to update the URL tests first to keep the PR small.

test: update wpt/resources to e1fddfbf80

Using git node wpt resources

test: use ShellTestEnvironment in WPT

So we no longer need to hack the global.location and pretend
that we are in a worker anymore.

test: update wpt/url to 418f7fabeb

Using git node wpt url

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • commit message follows commit guidelines

Using `git node wpt resources`
So we no longer need to hack the global.location and pretend
that we are in a worker anymore.
Using `git node wpt url`
@joyeecheung
Copy link
Member Author

cc @nodejs/testing @nodejs/open-standards

@nodejs-github-bot
Copy link
Collaborator

@joyeecheung joyeecheung added the test Issues and PRs related to the tests. label May 22, 2019
@nodejs-github-bot
Copy link
Collaborator

@joyeecheung joyeecheung added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label May 23, 2019
@joyeecheung
Copy link
Member Author

Landed in 3293bbf...df22778

joyeecheung added a commit that referenced this pull request May 24, 2019
Using `git node wpt resources`

PR-URL: #27822
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
joyeecheung added a commit that referenced this pull request May 24, 2019
So we no longer need to hack the global.location and pretend
that we are in a worker anymore.

PR-URL: #27822
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
joyeecheung added a commit that referenced this pull request May 24, 2019
Using `git node wpt url`

PR-URL: #27822
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
targos pushed a commit that referenced this pull request May 28, 2019
Using `git node wpt resources`

PR-URL: #27822
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
targos pushed a commit that referenced this pull request May 28, 2019
So we no longer need to hack the global.location and pretend
that we are in a worker anymore.

PR-URL: #27822
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
targos pushed a commit that referenced this pull request May 28, 2019
Using `git node wpt url`

PR-URL: #27822
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
@targos targos mentioned this pull request Jun 3, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. test Issues and PRs related to the tests.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants