Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: add testcase for SourceTextModule custom inspect #27889

Closed
wants to merge 1 commit into from
Closed

test: add testcase for SourceTextModule custom inspect #27889

wants to merge 1 commit into from

Conversation

ch1ller0
Copy link
Contributor

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • commit message follows commit guidelines

@nodejs-github-bot nodejs-github-bot added the test Issues and PRs related to the tests. label May 26, 2019
addaleax
addaleax approved these changes May 26, 2019
View reviewed changes
Copy link
Member

@addaleax addaleax left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, although I don’t think wrapping in an async function is necessary here?

@ch1ller0
Copy link
Contributor Author

LGTM, although I don’t think wrapping in an async function is necessary here?

thats right, it is not necessary)

@addaleax addaleax added the code-and-learn Issues related to the Code-and-Learn events and PRs submitted during the events. label May 26, 2019
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/23335/

ryzokuken
ryzokuken approved these changes May 26, 2019
View reviewed changes
Copy link
Contributor

@ryzokuken ryzokuken left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Kefir100 please remove any unnecessary keywords, please. Thanks for the PR. LGTM.

BridgeAR
BridgeAR approved these changes May 26, 2019
View reviewed changes
test/parallel/test-vm-module-basic.js Outdated Show resolved Hide resolved
@ch1ller0
Copy link
Contributor Author

@BridgeAR @ryzokuken fixed linter and also covered the line with getConstructorOf

@Trott Trott added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label May 27, 2019
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/23368/

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/23389/

@ryzokuken
Copy link
Contributor

Thanks everyone! Will land this as soon as 48 hours are up.

@ryzokuken
Copy link
Contributor

Landed in ff66e08 🎉

@ryzokuken ryzokuken closed this May 29, 2019
ryzokuken pushed a commit that referenced this pull request May 29, 2019
@ch1ller0 @ryzokuken
test: add testcase for SourceTextModule custom inspect
ff66e08 
PR-URL: #27889
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Ujjwal Sharma <usharma1998@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
@ch1ller0
Copy link
Contributor Author

Thanks everyone 👍

@ryzokuken
Copy link
Contributor

ryzokuken commented May 30, 2019 •
edited
Loading

🎉 Thanks for the contribution!

targos pushed a commit that referenced this pull request May 31, 2019
@ch1ller0 @targos
test: add testcase for SourceTextModule custom inspect
b5b234d 
PR-URL: #27889
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Ujjwal Sharma <usharma1998@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
@targos targos mentioned this pull request Jun 3, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ryzokuken ryzokuken ryzokuken approved these changes

@BridgeAR BridgeAR BridgeAR approved these changes

@gireeshpunathil gireeshpunathil gireeshpunathil approved these changes

@addaleax addaleax addaleax approved these changes

@Trott Trott Trott approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. code-and-learn Issues related to the Code-and-Learn events and PRs submitted during the events. test Issues and PRs related to the tests.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@ch1ller0 @nodejs-github-bot @ryzokuken @Trott @addaleax @gireeshpunathil @BridgeAR