Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: add test cases for paramEncoding 'explicit' #27900

Closed
wants to merge 1 commit into from
Closed

test: add test cases for paramEncoding 'explicit' #27900

wants to merge 1 commit into from

Conversation

oksemonenko
Copy link
Contributor

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • commit message follows commit guidelines

@nodejs-github-bot nodejs-github-bot added the test Issues and PRs related to the tests. label May 26, 2019
ryzokuken
ryzokuken reviewed May 26, 2019
View reviewed changes
Copy link
Contributor

@ryzokuken ryzokuken left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this!

/cc @tniessen @nodejs/crypto

@ryzokuken ryzokuken added the code-and-learn Issues related to the Code-and-Learn events and PRs submitted during the events. label May 26, 2019
@nodejs-github-bot

This comment has been minimized.

Sign in to view
@tniessen
Copy link
Member

Thanks for the ping @ryzokuken. Key pair generation is slow, I am not sure if this is worth adding three more test cases. Apart from that, LGTM.

@ChALkeR
Copy link
Member

ChALkeR commented May 27, 2019

@tniessen There were uncovered lines and this PR should increase actual coverage.
So this should be worth it =).

@tniessen
Copy link
Member

@ChALkeR Yes, we should definitely add one or more tests to cover those lines. I was just questioning the number of tests :) But you are right, it does not really matter if it's one or three.

@panva
Copy link
Member

panva commented May 27, 2019

@ChALkeR Yes, we should definitely add one or more tests to cover those lines. I was just questioning the number of tests :) But you are right, it does not really matter if it's one or three.

It's ec keys, not taxing.

ryzokuken
ryzokuken approved these changes May 27, 2019
View reviewed changes
Copy link
Contributor

@ryzokuken ryzokuken left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ChALkeR ChALkeR added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label May 28, 2019
@nodejs-github-bot

This comment has been minimized.

Sign in to view
@nodejs-github-bot

This comment has been minimized.

Sign in to view
@ryzokuken
Copy link
Contributor

Any idea what failed, everyone?

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/23447/

@ryzokuken
Copy link
Contributor 

03:26:26 /home/iojs/build/workspace/node-test-commit-plinux/nodes/ppcle-ubuntu1404/out/Release/obj.target/v8_base/deps/v8/src/bootstrapper.o:(.toc1+0x218): undefined reference to `v8::internal::StatisticsExtension::kSource'
03:26:26 /home/iojs/build/workspace/node-test-commit-plinux/nodes/ppcle-ubuntu1404/out/Release/obj.target/v8_base/deps/v8/src/bootstrapper.o:(.toc1+0x228): undefined reference to `vtable for v8::internal::StatisticsExtension'
03:26:26 collect2: error: ld returned 1 exit status
03:26:26 make[2]: *** [/home/iojs/build/workspace/node-test-commit-plinux/nodes/ppcle-ubuntu1404/out/Release/mksnapshot] Error 1

Seems to be a plinux flake, I'm seeing this multiple times everyday on unrelated PRs.

@Trott we're tracking this one, right?

@BridgeAR
Copy link
Member

@oksemonenko thanks a lot and I hope you enjoyed the event!

@oksemonenko
Copy link
Contributor Author

@oksemonenko thanks a lot and I hope you enjoyed the event!

@BridgeAR of course I did! Thank you very much for making my sunday!

@ryzokuken
Copy link
Contributor

@BridgeAR since the CI fail is flaky, I guess it's fine to rerun CI?

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/23456/

@tniessen
Copy link
Member

CI is green and the last failure looks a lot like a flake:

08:39:59 not ok 2562 known_issues/test-vm-timeout-escape-queuemicrotask
08:39:59   ---
08:39:59   duration_ms: 0.448
08:39:59   severity: fail
08:39:59   stack: |-
08:39:59   ...

So this should be good to go.

@Trott
Copy link
Member

Trott commented May 30, 2019

Landed in 76cffdd.

@Trott Trott closed this May 30, 2019
Trott pushed a commit to Trott/io.js that referenced this pull request May 30, 2019
@oksemonenko @Trott
test: add test cases for paramEncoding 'explicit'
76cffdd 
PR-URL: nodejs#27900
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Ujjwal Sharma <usharma1998@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Rich Trott <rtrott@gmail.com>
@tniessen tniessen removed the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label May 30, 2019
targos pushed a commit that referenced this pull request May 31, 2019
@oksemonenko @targos
test: add test cases for paramEncoding 'explicit'
6f9aa3f 
PR-URL: #27900
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Ujjwal Sharma <usharma1998@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Rich Trott <rtrott@gmail.com>
@targos targos mentioned this pull request Jun 3, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ryzokuken ryzokuken ryzokuken approved these changes

@BridgeAR BridgeAR BridgeAR approved these changes

@tniessen tniessen tniessen approved these changes

@Trott Trott Trott approved these changes

Assignees
No one assigned
Labels
code-and-learn Issues related to the Code-and-Learn events and PRs submitted during the events. test Issues and PRs related to the tests.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@oksemonenko @nodejs-github-bot @tniessen @ChALkeR @panva @ryzokuken @BridgeAR @Trott