Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

trace_events: respect inspect() depth #28037

Merged
merged 1 commit into from
Jun 5, 2019
Merged

trace_events: respect inspect() depth #28037

merged 1 commit into from
Jun 5, 2019

Conversation

cjihrig
Copy link
Contributor

@cjihrig cjihrig commented Jun 3, 2019

This commit causes the Tracing class to account for util.inspect() depth.

Similar to #27983. After this commit, all of these cases in core are handled.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • commit message follows commit guidelines

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/23590/

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/23591/

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/23593/

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/23595/

@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Jun 3, 2019 •
edited by cjihrig
Loading

CI: https://ci.nodejs.org/job/node-test-pull-request/23597/

EDIT(cjihrig): CI was yellow.

@BridgeAR BridgeAR added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. trace_events Issues and PRs related to V8, Node.js core, and userspace code trace events. util Issues and PRs related to the built-in util module. labels Jun 4, 2019
@cjihrig
trace_events: respect inspect() depth
81a9c72 
This commit causes the Tracing class to account for
util.inspect() depth.

PR-URL: nodejs#28037
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
@cjihrig cjihrig merged commit 81a9c72 into nodejs:master Jun 5, 2019
@cjihrig cjihrig deleted the custom-inspect branch June 5, 2019 19:42
BridgeAR pushed a commit that referenced this pull request Jun 17, 2019
@cjihrig @BridgeAR
trace_events: respect inspect() depth
9dd840d 
This commit causes the Tracing class to account for
util.inspect() depth.

PR-URL: #28037
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
@BridgeAR BridgeAR mentioned this pull request Jun 17, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BridgeAR BridgeAR BridgeAR approved these changes

@lpinca lpinca lpinca approved these changes

@addaleax addaleax addaleax approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. trace_events Issues and PRs related to V8, Node.js core, and userspace code trace events. util Issues and PRs related to the built-in util module.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@cjihrig @nodejs-github-bot @addaleax @lpinca @BridgeAR