Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: clarify special schemes #28091

Merged
merged 1 commit into from
Jun 9, 2019
Merged

doc: clarify special schemes #28091

merged 1 commit into from
Jun 9, 2019

Conversation

Trott
Copy link
Member

@Trott Trott commented Jun 6, 2019

In url.md, describe protocol schemes as "deemed special by the
[standard]" rather than "considered to be special by the [standard]".
The use of "considered to be" suggests that they might not really be.
While "deemed" is a synonym for the most part, it connotes less doubt.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • documentation is changed or added
  • commit message follows commit guidelines

@targos
Copy link
Member

targos commented Jun 6, 2019

what about "defined as" ?

@Trott Trott force-pushed the considered-2-be branch 2 times, most recently from a1fc4e1 to 33583e6 Compare June 6, 2019 10:58
@Trott
Copy link
Member Author

Trott commented Jun 6, 2019

what about "defined as" ?

@targos How's this?:

According to the WHATWG URL Standard, special protocol schemes include `ftp`,
`file`, `gopher`, `http`, `https`, `ws`, and `wss`.

@Trott Trott added doc Issues and PRs related to the documentations. whatwg-url Issues and PRs related to the WHATWG URL implementation. labels Jun 6, 2019
@Trott
Copy link
Member Author

Trott commented Jun 6, 2019

@Trott Trott added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Jun 6, 2019
doc/api/url.md Outdated Show resolved Hide resolved
@Trott
Copy link
Member Author

Trott commented Jun 9, 2019

In url.md, describe "special" protocol schemes as "special" rather than
"considered to be special".

PR-URL: nodejs#28091
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Tiancheng "Timothy" Gu <timothygu99@gmail.com>
@Trott
Copy link
Member Author

Trott commented Jun 9, 2019

Landed in d71f05c

@Trott Trott merged commit d71f05c into nodejs:master Jun 9, 2019
@Trott Trott deleted the considered-2-be branch June 9, 2019 01:55
BridgeAR pushed a commit that referenced this pull request Jun 17, 2019
In url.md, describe "special" protocol schemes as "special" rather than
"considered to be special".

PR-URL: #28091
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Tiancheng "Timothy" Gu <timothygu99@gmail.com>
@BridgeAR BridgeAR mentioned this pull request Jun 17, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. doc Issues and PRs related to the documentations. whatwg-url Issues and PRs related to the WHATWG URL implementation.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants