doc: improve DEP0090 text #28097
Merged
doc: improve DEP0090 text #28097
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Sadly, an error occurred when I tried to trigger a build. :( |
nodejs-github-bot
added
deprecations
BridgeAR
approved these changes
Jun 6, 2019
Trott
added
the
author ready
BethGriggs
approved these changes
Jun 6, 2019
cjihrig
approved these changes
Jun 6, 2019
trivikr
approved these changes
Jun 6, 2019
Edit text for "DEP0090: Invalid GCM authentication tag lengths" for clarity and branding. Invalid langths are "invalid" rather than "considered invalid". Refer to "Node.js v11.0.0" rather than "node v11.0.0". PR-URL: nodejs#28097 Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Beth Griggs <Bethany.Griggs@uk.ibm.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
|
Landed in c046011 |
BridgeAR
pushed a commit
that referenced
this pull request
Jun 17, 2019
Edit text for "DEP0090: Invalid GCM authentication tag lengths" for clarity and branding. Invalid langths are "invalid" rather than "considered invalid". Refer to "Node.js v11.0.0" rather than "node v11.0.0". PR-URL: #28097 Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Beth Griggs <Bethany.Griggs@uk.ibm.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Edit text for "DEP0090: Invalid GCM authentication tag lengths" for
clarity and branding. Invalid langths are "invalid" rather than
"considered invalid". Refer to "Node.js v11.0.0" rather than "node
v11.0.0".
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes