test: move the corresponding IPv4 and IPv6 tests

[zero1five]

Move the IPv4 and IPv6 test in the isIp file to the corresponding file,
and remove non-string tests(isIP test is only for string input).

Checklist

• make -j4 test (UNIX), or vcbuild test (Windows) passes
• tests and/or benchmarks are included
• documentation is changed or added
• commit message follows commit guidelines

[BridgeAR]

@zero1five Thanks a lot for your change but I have some concerns with this:

In case of a failure the test would only report e.g. 0 !== 4. It would not tell what ip was used in the specific test. Thus, the usefulness seems to decrease due to the change.

It also removes a couple of tests that do not seem to be duplicated tests. For those reasons I am -1 on this change.

[BridgeAR]

These cases are not tested in the other file. Is there a specific reason for removing them?

[zero1five]

About this, I think isIPxx since it only supports string input, testing non-string input is an unnecessary test, don't get useful feedback in run the test case.

I'm not sure if it should do this kind of testing in node, imo, It is up to the user to make a simple assertion before using it.

[BridgeAR]

I am not certain I can follow. We verify that the API works as expected and to have a full coverage.

[zero1five]

@BridgeAR Yes! I ignored the fact that the error message was not very readable, so I made some changes, and it now looks like this:

assert.js:89
  throw new AssertionError(obj);
  ^

AssertionError [ERR_ASSERTION]: 

net.isIPv6('1:') !== true

    at validateIsIPv6 (...)
    at Array.forEach (<anonymous>)
    ...

add error messages to make it easier to read.

[jasnell]

Ping @BridgeAR, looks like this needed a follow up review from you.

[aduh95]

@zero1five This would need a rebase to solve the conflicts.

[github-actions]

This issue/PR was marked as stalled, it will be automatically closed in 30 days. If it should remain open, please leave a comment explaining why it should remain open.

[github-actions]

Closing this because it has stalled. Feel free to reopen if this PR is still relevant, or to ping the collaborator who labelled it stalled if you have any questions.