test: skip test-worker-prof on all platforms.

[miladfarca]

There was a problem with V8 GC which potentially could
crash this test on all platforms. Issue is fixed on V8 master. SKIPPING until
the V8 patch is backported to 7.5 and 7.6.

Bug:
https://bugs.chromium.org/p/v8/issues/detail?id=9333

[sam-github]

@miladfarca Could you rebase this to get rid of the merge commits? git fetch -a; git rebase upstream/master; git push --force-with-leaase should do it.

Also, could you link to a nodejs/node issue in the .status file? That allows someone who is later looking at the skipped files to find the source bug and its state - the v8 issue won't indicate when the bug fix has landed in node master (I don't think). Once the status file is linked to a nodejs/node github issue, you won't need the explanatory text, either, since it will be in the issue.

[miladfarca]

@sam-github Top of the comment includes the original nodejs issue https://github.com/nodejs/node/issues/26401, should remove the comments?

[mhdawson]

As a note, while this can fail on all platforms it seems to fail very regularly on PPC resulting in yellow builds. I'm in agreement that skipping until we get the fix in will be good for CI hygiene.

[mhdawson]

LGTM

[miladfarca]

@sam-github I have done a rebase but the merge commits aren't going away.

[nodejs-github-bot]

CI: https://ci.nodejs.org/job/node-test-pull-request/23799/

[targos]

This test also reliably times out on my computer (Fedora 30). I think it started after the latest kernel update.

[miladfarca]

@targos It would timeout on any machine if V8 GC thinks heap needs a cleanup, not architecture dependent, thats why it was passing and failing irregularly on our end.

[BridgeAR]

@miladfarca

@sam-github I have done a rebase but the merge commits aren't going away

They will only go away in case you push force your local rebased branch. So what you can do is:

git fetch upstream
git checkout master
git rebase -i upstream/master
git push --force-with-lease

As a side note: it's likely better to create a feature branch instead of using master for future pull requests :) The steps above should work in case https://github.com/nodejs/node is called upstream.

I guess in this specific case we could go ahead and land this PR without a CI run. Depending on what other collaborators think.

[sam-github]

Agreed, this can land without CI, since the only thing it does is add one SKIPed test.

[sam-github]

I force pushed @miladfarca 's branch (well, master...), squashed the fixup, and rewrote the commit description to fit in the 50 chars (cause of Travis CI failure, I assume).

[sam-github]

ci-lite: https://ci.nodejs.org/job/node-test-pull-request-lite-pipeline/3677/

[addaleax]

Landed in b614840

That being said:

• The reason that this times out instead of crashing outright is that src: enable V8's WASM trap handlers #27246 was buggy. I’ve just landed src: fix segfault handling/RegisterSignalHandler #27775 which addresses those issues.
• I’d strongly prefer to actually backport the relevant V8 commit instead of skipping tests. That’s what we generally do for real bugs, unless we can’t fix them, but in this case I see no reason not to. I’ll open a PR shortly.

Edit: Just saw that this has been approved for merging into V8 7.5. I think we still want to have the fix on Node v10.x, so we should open a PR for that, but I guess that can wait until after we’ve updated our V8 version.