Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

https: do not automatically use invalid servername #28209

Closed
wants to merge 1 commit into from
Closed

https: do not automatically use invalid servername #28209

wants to merge 1 commit into from

Commits on Jun 14, 2019

  1. https: do not automatically use invalid servername 

    Stop automatically setting servername in https.request() if the target
host is specified with an IP address. Doing so is invalid, and triggers
a deprecation warning. It is still possible to send an IP address as a
servername if its required, but it needs to be explicity configured, it
won't happen automatically.
    @sam-github
    sam-github committed Jun 14, 2019
    Configuration menu
    Copy the full SHA
    9bbc7d9 View commit details
    Browse the repository at this point in the history