Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: fix cctest target for --without-report #28238

Closed
wants to merge 1 commit into from

Conversation

richardlau
Copy link
Member

@richardlau richardlau commented Jun 15, 2019

Conditionally build test/cctest/test_report_util.cc only when
configured to include the diagnostic report feature.

Fixes the following link error when configured with --without-report:

/home/users/riclau/sandbox/github/nodejs/out/Release/obj.target/cctest/test/cctest/test_report_util.o: In function `ReportUtilTest_EscapeJsonChars_Test::TestBody()':
test_report_util.cc:(.text+0x57): undefined reference to `report::EscapeJsonChars(std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > const&)'
test_report_util.cc:(.text+0x1ad): undefined reference to `report::EscapeJsonChars(std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > const&)'
test_report_util.cc:(.text+0x302): undefined reference to `report::EscapeJsonChars(std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > const&)'
test_report_util.cc:(.text+0x44a): undefined reference to `report::EscapeJsonChars(std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > const&)'
test_report_util.cc:(.text+0x592): undefined reference to `report::EscapeJsonChars(std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > const&)'
/home/users/riclau/sandbox/github/nodejs/out/Release/obj.target/cctest/test/cctest/test_report_util.o:test_report_util.cc:(.text+0xd7a): more undefined references to `report::EscapeJsonChars(std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > const&)' follow
collect2: error: ld returned 1 exit status
make[1]: *** [/home/users/riclau/sandbox/github/nodejs/out/Release/cctest] Error 1

cc @nodejs/build-files

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines

Conditionally build `test/cctest/test_report_util.cc` only when
configured to include the diagnostic report feature.
@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Jun 15, 2019

Sadly, an error occurred when I tried to trigger a build. :(
CI: https://ci.nodejs.org/job/node-test-pull-request/23896/
CI: https://ci.nodejs.org/job/node-test-pull-request/23899/

@nodejs-github-bot nodejs-github-bot added the build Issues and PRs related to build files or the CI. label Jun 15, 2019
@richardlau richardlau added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Jun 17, 2019
@BridgeAR
Copy link
Member

Landed in c72506c 🎉

BridgeAR pushed a commit to BridgeAR/node that referenced this pull request Jun 17, 2019
Conditionally build `test/cctest/test_report_util.cc` only when
configured to include the diagnostic report feature.

PR-URL: nodejs#28238
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
@BridgeAR BridgeAR closed this Jun 17, 2019
BridgeAR pushed a commit that referenced this pull request Jun 17, 2019
Conditionally build `test/cctest/test_report_util.cc` only when
configured to include the diagnostic report feature.

PR-URL: #28238
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
@BridgeAR BridgeAR mentioned this pull request Jun 17, 2019
targos pushed a commit that referenced this pull request Jun 18, 2019
Conditionally build `test/cctest/test_report_util.cc` only when
configured to include the diagnostic report feature.

PR-URL: #28238
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. build Issues and PRs related to build files or the CI.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants