Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

win: backport manifest for v0.10 #2838

Closed
wants to merge 2 commits into from
Closed

win: backport manifest for v0.10 #2838

wants to merge 2 commits into from

Commits on Sep 12, 2015

  1. win: manifest node.exe for Windows 8.1 

    This is a port of 03e9352 .

Original commit message:

  Adding a compatibility section to node.exe embedded manifest so that
  Node is declared explicitly compatible with Windows 8.1. Required so
  that os.release() can return the correct version on Windows 8.1.

  See http://msdn.microsoft.com/en-us/library/windows/desktop/ms724451(v=vs.85).aspx

  Reviewed-by: Trevor Norris <trev.norris@gmail.com>
    @orangemocha @joaocgreis
    orangemocha authored and joaocgreis committed Sep 12, 2015
    Configuration menu
    Copy the full SHA
    3790f50 View commit details
    Browse the repository at this point in the history

  2. build: update manifest to include Windows 10 

    This is a port of b0dd3bf .

Original commit message:

  Windows 10 wasn't listed in the executable manifest.
  This caused problems with trying to detect Windows 10
  via `os.release()`.

  PR-URL: nodejs#2332
  Reviewed-By: Roman Reiss <me@silverwind.io>
    @LPGhatguy @joaocgreis
    LPGhatguy authored and joaocgreis committed Sep 12, 2015
    Configuration menu
    Copy the full SHA
    9f34969 View commit details
    Browse the repository at this point in the history