Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

build: avoid building V8 snapshot if --without-snapshot #28467

Closed
wants to merge 1 commit into from
Closed

build: avoid building V8 snapshot if --without-snapshot #28467

wants to merge 1 commit into from

Conversation

targos
Copy link
Member

@targos targos commented Jun 28, 2019

@nodejs-github-bot nodejs-github-bot added the build Issues and PRs related to build files or the CI. label Jun 28, 2019
@targos targos mentioned this pull request Jun 28, 2019
Closed
@devsnek
Copy link
Member

devsnek commented Jun 28, 2019

cc @joyeecheung

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/24146/

joyeecheung
joyeecheung approved these changes Jun 28, 2019
View reviewed changes
Copy link
Member

@joyeecheung joyeecheung left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit for the commit message: “avoid building the default v8 snapshot...” for clarity (or maybe not, but when I saw the title I thought this was to make —without-snapshot imply —without-node-snapshot)

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/24156/

@refack
Copy link
Contributor

refack commented Jun 28, 2019

Refs: #27838 (comment)
/CC @hashseed is it worth it to fight for "no snapshot"?

refack
refack reviewed Jun 28, 2019
View reviewed changes
common.gypi
['OS == "mac"', {
'obj_dir%': '<(PRODUCT_DIR)/obj.target',
'v8_base': '<(PRODUCT_DIR)/libv8_snapshot.a',
['v8_use_snapshot==1', {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we de-dup this a little bit?

    ['v8_use_snapshot==1', {
      'v8_lib_name': 'snapshot',
    }, {
      'v8_lib_name': 'nosnapshot',
    }],
    ['GENERATOR == "ninja"', {
      'obj_dir': '<(PRODUCT_DIR)/obj',
      'v8_base': '<(PRODUCT_DIR)/obj/tools/v8_gypfiles/libv8_<(v8_lib_name).a',
    }, {
      'obj_dir%': '<(PRODUCT_DIR)/obj.target',
      'v8_base': '<(PRODUCT_DIR)/obj.target/tools/v8_gypfiles/libv8_<(v8_lib_name).a',
    }],
    ['OS == "win"', {
      'obj_dir': '<(PRODUCT_DIR)/obj',
      'v8_base': '<(PRODUCT_DIR)/lib/libv8_<(v8_lib_name).a',
    }],
    ['OS == "mac"', {
      'obj_dir%': '<(PRODUCT_DIR)/obj.target',
      'v8_base': '<(PRODUCT_DIR)/libv8_<(v8_lib_name).a',
    }],

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@refack:

gyp: Undefined variable v8_lib_name in /home/mzasso/git/nodejs/node/node.gyp while trying to load /home/mzasso/git/nodejs/node/node.gyp

@hashseed
Copy link
Member

Fwiw we want to remove no snapshot builds from V8 by the end of this year. We are working on the blockers of that right now. Reason is that it now takes unreasonable amount of time to run without snapshot, and also doesn't match what we ship.

@targos
Copy link
Member Author

targos commented Jun 29, 2019

That's good to know. We should probably remove or at least deprecate nosnapshot support in v13 then.

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/24239/

@BridgeAR BridgeAR added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Jul 4, 2019
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/24310/

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/24314/

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/24319/

@targos
Copy link
Member Author

targos commented Jul 6, 2019

The same tests failed three times in a row. It seems unlikely to be a flake, but they didn't fail in previous runs. I don't know what to do now...

@addaleax
Copy link
Member

addaleax commented Jul 6, 2019

  • 'CERT_HAS_EXPIRED'
  • 'DEPTH_ZERO_SELF_SIGNED_CERT'

Sounds like maybe an issue with the time config for the CI machine? /cc @nodejs/build-infra

@targos
build: do not always build the default V8 snapshot
995ecd3 
It should be skipped if Node.js is built with the --without-snapshot
configure flag.
@targos
Copy link
Member Author

targos commented Jul 12, 2019

I rebased on master and reworded the commit message. Maybe CI will pass now.

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/24399/

@targos
Copy link
Member Author

targos commented Jul 12, 2019

Landed in a8ed416

@targos targos closed this Jul 12, 2019
@targos targos deleted the really-no-snapshot branch July 12, 2019 14:32
targos added a commit that referenced this pull request Jul 12, 2019
@targos
build: do not always build the default V8 snapshot
a8ed416 
It should be skipped if Node.js is built with the --without-snapshot
configure flag.

PR-URL: #28467
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Ujjwal Sharma <usharma1998@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
targos added a commit that referenced this pull request Jul 20, 2019
@targos
build: do not always build the default V8 snapshot
171c8f4 
It should be skipped if Node.js is built with the --without-snapshot
configure flag.

PR-URL: #28467
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Ujjwal Sharma <usharma1998@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
This was referenced Jul 23, 2019
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@refack refack refack left review comments

@bnoordhuis bnoordhuis bnoordhuis approved these changes

@Trott Trott Trott approved these changes

@cjihrig cjihrig cjihrig approved these changes

@joyeecheung joyeecheung joyeecheung approved these changes

@richardlau richardlau richardlau approved these changes

@ryzokuken ryzokuken ryzokuken approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. build Issues and PRs related to build files or the CI.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.