Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: skip tests related to CI failures on AIX #28469

Closed
wants to merge 2 commits into from
Closed

test: skip tests related to CI failures on AIX #28469

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1ecc89a
test: skip tests related to CI failures on AIX
sam-github Jun 28, 2019
cbd3c89
fixup! test: skip tests related to CI failures on AIX
sam-github Jun 28, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions test/addons/stringbytes-external-exceed-max/test-stringbytes-external-exceed-max.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,11 @@ const skipMessage = 'intensive toString tests due to memory confinements';
if (!common.enoughTestMem)
common.skip(skipMessage);

// See https://github.com/nodejs/build/issues/1820#issuecomment-505998851
// See https://github.com/nodejs/node/pull/28469
if (process.platform === 'aix')
common.skip('flaky on AIX');

const binding = require(`./build/${common.buildType}/binding`);

// v8 fails silently if string length > v8::String::kMaxLength
Expand Down
3 changes: 3 additions & 0 deletions test/message/message.status
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,3 +16,6 @@ prefix message

[$system==freebsd]

[$system==aix]
# https://github.com/nodejs/node/pull/28469
vm_dont_display_syntax_error: SKIP
4 changes: 4 additions & 0 deletions test/pseudo-tty/pseudo-tty.status
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,10 @@
prefix pseudo-tty

[$system==aix]
# https://github.com/nodejs/build/issues/1820#issuecomment-505998851
# https://github.com/nodejs/node/pull/28469
console-dumb-tty: SKIP
test-fatal-error: SKIP

[$system==solaris]
# https://github.com/nodejs/node/pull/16225 - `ioctl(fd, TIOCGWINSZ)` seems
Expand Down
3 changes: 3 additions & 0 deletions test/sequential/sequential.status
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,5 +19,8 @@ test-http2-large-file: PASS, FLAKY
[$system==freebsd]

[$system==aix]
# https://github.com/nodejs/node/pull/28469
test-async-wrap-getasyncid: SKIP
test-buffer-creation-regression: SKIP

[$arch==arm]