Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

doc: fix link from bootstrap README to BUILDING #28504

Closed
wants to merge 1 commit into from
Closed

doc: fix link from bootstrap README to BUILDING #28504

wants to merge 1 commit into from

Conversation

rvagg
Copy link
Member

@rvagg rvagg commented Jul 2, 2019

I messed up #28465 and only noticed after it landed. tools/bootstrap/README.md points to README.md when it should point to BUILDING.md.

Here's the rendered version if you want to confirm I have it right this time.

@rvagg rvagg added doc Issues and PRs related to the documentations. build Issues and PRs related to build files or the CI. labels Jul 2, 2019
@nodejs-github-bot nodejs-github-bot added the tools Issues and PRs related to the tools directory. label Jul 2, 2019
@rvagg rvagg mentioned this pull request Jul 2, 2019
Closed
@trivikr
Copy link
Member

trivikr commented Jul 2, 2019

Like this comment to fast track this changes

@trivikr trivikr added the fast-track PRs that do not need to wait for 48 hours to land. label Jul 2, 2019
@trivikr
Copy link
Member

trivikr commented Jul 2, 2019

CI lite: https://ci.nodejs.org/job/node-test-pull-request-lite-pipeline/3734/

@trivikr trivikr added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Jul 2, 2019
@Trott
Copy link
Member

Trott commented Jul 2, 2019

Landed in 3ab457e

@Trott Trott closed this Jul 2, 2019
Trott pushed a commit to Trott/io.js that referenced this pull request Jul 2, 2019
@rvagg @Trott
doc: fix link from bootstrap README to BUILDING
3ab457e 
PR-URL: nodejs#28504
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
targos pushed a commit that referenced this pull request Jul 20, 2019
@rvagg @targos
doc: fix link from bootstrap README to BUILDING
68ed32f 
PR-URL: #28504
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
This was referenced Jul 23, 2019
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ZYSzys ZYSzys ZYSzys approved these changes

@trivikr trivikr trivikr approved these changes

@richardlau richardlau richardlau approved these changes

@lpinca lpinca lpinca approved these changes

@Trott Trott Trott approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. build Issues and PRs related to build files or the CI. doc Issues and PRs related to the documentations. fast-track PRs that do not need to wait for 48 hours to land. tools Issues and PRs related to the tools directory.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@rvagg @trivikr @Trott @lpinca @richardlau @ZYSzys @nodejs-github-bot